[PATCH 1/2] d3d10core/tests: Run test_generate_mips separately.
Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- Similar problem as test_instanced_draw, but much less reliable. I suspect it is behind test failures like http://test.winehq.org/data/695c320507f89539378b93bcf8221b1bc8965325/win2009... --- dlls/d3d10core/tests/d3d10core.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/dlls/d3d10core/tests/d3d10core.c b/dlls/d3d10core/tests/d3d10core.c index 287292ebb5f..ffab5cbfca3 100644 --- a/dlls/d3d10core/tests/d3d10core.c +++ b/dlls/d3d10core/tests/d3d10core.c @@ -19319,7 +19319,6 @@ START_TEST(d3d10core) queue_test(test_compressed_format_compatibility); queue_test(test_clip_distance); queue_test(test_combined_clip_and_cull_distances); - queue_test(test_generate_mips); queue_test(test_alpha_to_coverage); queue_test(test_unbound_multisample_texture); queue_test(test_multiple_viewports); @@ -19338,11 +19337,10 @@ START_TEST(d3d10core) run_queued_tests(); - /* There should be no reason this test can't be run in parallel with the - * others, yet it fails when doing so. (AMD Radeon HD 6310, Windows 7) */ + /* There should be no reason these tests can't be run in parallel with the + * others, yet they randomly fail or crash when doing so. + * (AMD Radeon HD 6310, Radeon 560, Windows 7 and Windows 10) */ test_stream_output_vs(); - /* Same here, this test fails randomly on Win10 when run together with - * others on Radeon GPUs. Radeon 560 (0x1002:0x67ef), both on the testbot - * and Stefan's macbook. */ test_instanced_draw(); + test_generate_mips(); } -- 2.34.1
Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- I have not yet seen the d3d11 version of test_stream_output_vs crash on my systems. --- dlls/d3d11/tests/d3d11.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 2dfb1cc0bf5..0d91d828676 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -34088,7 +34088,6 @@ START_TEST(d3d11) test_compressed_format_compatibility); queue_test(test_clip_distance); queue_test(test_combined_clip_and_cull_distances); - queue_test(test_generate_mips); queue_test(test_alpha_to_coverage); queue_test(test_unbound_multisample_texture); queue_test(test_multiple_viewports); @@ -34116,8 +34115,9 @@ START_TEST(d3d11) run_queued_tests(); - /* This test fails randomly on Win10 when run together with others - * on Radeon GPUs. Radeon 560 (0x1002:0x67ef), both on the testbot - * and Stefan's macbook. */ + /* There should be no reason these tests can't be run in parallel with the + * others, yet they randomly fail or crash when doing so. + * (Radeon 560, Windows 10) */ test_instanced_draw(); + test_generate_mips(); } -- 2.34.1
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=105177 Your paranoid android. === build (build log) === error: patch failed: dlls/d3d11/tests/d3d11.c:34001 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/d3d11/tests/d3d11.c:34001 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/d3d11/tests/d3d11.c:34001 Task: Patch failed to apply
Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>
participants (3)
-
Henri Verbeet -
Marvin -
Stefan Dösinger