Re: comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

[Daniel Jeliński]

Hi Dmitry,
After this patch got applied, the code looks like this:
(
http://source.winehq.org/git/wine.git/blob/cc086f09ae46c77e6eb4a817ae567294d...
)
1914 if (!GetObjectW((infoPtr->hFont) ?
1915 infoPtr->hFont : GetStockObject(DEFAULT_GUI_FONT),
1916 sizeof(LOGFONTW),&logfont))
1917 GetStockObject(DEFAULT_GUI_FONT);

I'm quite sure you didn't mean to ignore return value of GetStockObject and
leave logfont uninitialized here.

Regards,
Daniel

(sorry for being late to the party, I'm not subscribing wine-patches, and
kind of assumed this patch wouldn't get past AJ)

comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

[Dmitry Timoshkov]

Daniel Jeliński <djelinski1(a)gmail.com> wrote:
> I'm quite sure you didn't mean to ignore return value of GetStockObject and
> leave logfont uninitialized here.

GetStockObject(DEFAULT_GUI_FONT) can't fail.

-- 
Dmitry.

comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

[Ken Thomases]

On Jun 18, 2013, at 1:26 AM, Dmitry Timoshkov wrote:
> Daniel Jeliński <djelinski1(a)gmail.com> wrote:
> > I'm quite sure you didn't mean to ignore return value of GetStockObject and
> > leave logfont uninitialized here.
>
> GetStockObject(DEFAULT_GUI_FONT) can't fail.

I think the question is: what does line 1917 do?
http://source.winehq.org/git/wine.git/blob/cc086f09ae46c77e6eb4a817ae567294d...

Does GetStockObject(DEFAULT_GUI_FONT) have some sort of side effect that's not obvious?

-Ken