Re: widl: Use is_string_type for detecting strings in write_typeformatstring_var to make it consistent with write_remoting_arg.
Robert Shearman <rob(a)codeweavers.com> writes:
Fix the is_string_type function used for detecting strings by only examining aliases instead of both aliases and pointers. This is due to the requirement that pointers to strings be handled as pointers and so not detected as strings.
This breaks qmgr: ../../../tools/runtest -q -P wine -M qmgr.dll -T ../../.. -p qmgr_test.exe.so file.c && touch file.ok file.c:127: Test failed: Got incorrect remote name file.c:144: Test failed: Got incorrect local name make: *** [file.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org
Alexandre Julliard wrote:
Robert Shearman <rob(a)codeweavers.com> writes:
Fix the is_string_type function used for detecting strings by only examining aliases instead of both aliases and pointers. This is due to the requirement that pointers to strings be handled as pointers and so not detected as strings.
This breaks qmgr:
../../../tools/runtest -q -P wine -M qmgr.dll -T ../../.. -p qmgr_test.exe.so file.c && touch file.ok file.c:127: Test failed: Got incorrect remote name file.c:144: Test failed: Got incorrect local name make: *** [file.ok] Error 2
Thanks, there was a typo in the patch. I'll resend it with the typo fixed. I believe the patches titled "widl: Support using context handles as the binding handle in client functions." and "widl: Add support for generic binding handles." will still apply without this patch being committed first. -- Rob Shearman
participants (2)
-
Alexandre Julliard -
Robert Shearman