Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel
On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote:
Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> --- programs/winecfg/Bg.rc | 19 +++++---- programs/winecfg/Cs.rc | 19 +++++---- programs/winecfg/Da.rc | 19 +++++---- programs/winecfg/De.rc | 19 +++++---- programs/winecfg/En.rc | 19 +++++---- programs/winecfg/Es.rc | 19 +++++---- programs/winecfg/Fi.rc | 19 +++++---- programs/winecfg/Fr.rc | 19 +++++---- programs/winecfg/Hu.rc | 19 +++++---- programs/winecfg/It.rc | 19 +++++---- programs/winecfg/Ja.rc | 19 +++++---- programs/winecfg/Ko.rc | 19 +++++---- programs/winecfg/Lt.rc | 19 +++++---- programs/winecfg/Nl.rc | 19 +++++---- programs/winecfg/No.rc | 19 +++++---- programs/winecfg/Pl.rc | 19 +++++---- programs/winecfg/Pt.rc | 32 +++++++------- programs/winecfg/Ro.rc | 19 +++++---- programs/winecfg/Ru.rc | 19 +++++---- programs/winecfg/Si.rc | 19 +++++---- programs/winecfg/Sv.rc | 19 +++++---- programs/winecfg/Tr.rc | 19 +++++---- programs/winecfg/Zh.rc | 38 +++++++++-------- programs/winecfg/about.c | 88 +++++++++++++++++++++++++++++++++++++++++ programs/winecfg/idb_wine.bmp | Bin 14614 -> 0 bytes programs/winecfg/resource.h | 7 +++- programs/winecfg/winecfg.rc | 4 +- 27 files changed, 342 insertions(+), 226 deletions(-) delete mode 100644 programs/winecfg/idb_wine.bmp
Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?
Joel Holdsworth wrote:
On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote:
Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> --- programs/winecfg/Bg.rc | 19 +++++----
Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?
Does it fix a bug? If not, AJ may have placed it aside until after Wine 1.2 is released.
On Tue, Jun 8, 2010 at 03:41, James McKenzie <jjmckenzie51(a)earthlink.net> wrote:
Joel Holdsworth wrote:
On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote:
Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> --- programs/winecfg/Bg.rc | 19 +++++----
Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?
Does it fix a bug? If not, AJ may have placed it aside until after Wine 1.2 is released.
Indeed. Adding new strings to translate will/should probably have to wait until after Wine 1.2, so we can get as many languages as possible at 100% when 1.2 is released. OTOH, if it new strings fix a problem, then go for it. Frédéric
Does it fix a bug? If not, AJ may have placed it aside until after Wine 1.2 is released.
Indeed. Adding new strings to translate will/should probably have to wait until after Wine 1.2, so we can get as many languages as possible at 100% when 1.2 is released.
OTOH, if it new strings fix a problem, then go for it.
The patch doesn't add any new strings - just modifies the dialog layout: http://www.airwebreathe.org.uk/space/new-about-screen.png . I'm trying to give the about panel a degree of graphical polish in time for the release.
On Tue, Jun 8, 2010 at 1:17 AM, Joel Holdsworth <joel(a)airwebreathe.org.uk> wrote:
Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?
It says apply failure for 3/3, so that's probably why 2/3 wasn't committed also. Problem is that there are a lot of translation updates these days and some patches affect winecfg .rc files. I guess you should rebase on git head and resend patch. However, I see there is still one patch on the pipe that affects Es.rc from winecfg, so that might again cause some problems. Octavian
It says apply failure for 3/3, so that's probably why 2/3 wasn't committed also.
Problem is that there are a lot of translation updates these days and some patches affect winecfg .rc files. I guess you should rebase on git head and resend patch. However, I see there is still one patch on the pipe that affects Es.rc from winecfg, so that might again cause some problems.
Octavian
Ok, I've rebased now, fixed up the problems, and resubmitted.
participants (4)
-
Frédéric Delanoy -
James McKenzie -
Joel Holdsworth -
Octavian Voicu