Re: wined3d: Allow color key processing for surfaces with alpha channel

[Stefan Dösinger]

Am Mittwoch 24 November 2010, 12:38:00 schrieb Ilya Shpigor:
> Hello!
>
> This is new patch for  bug:
> http://bugs.winehq.org/show_bug.cgi?id=23750
>
> I have tested color key processing for SURFACE_OPENGL and SURFACE_GDI
> surfaces with alpha channel in Windows.The color key has been processed
> for both surface types.
> I'm not sure I understand - SURFACE_OPENGL and SURFACE_GDI are wine specific, 
> how did you test on Windows?
> I don't know how to write correct Wine test for this problem. Can anybody
> help me?
> Is this Wine test realy needed?
> Yes, we need a test for this patch, as it contradicts documentation I have 
> previously read. A Nvidia document about color keying emulation states that 
> Nvidia drivers ignore color keying on Alpha 3D textures. Thus we need a test 
> to (a) be sure that the patch is correct and (b) make sure we don't revert the 
> patch if reverting it happens to fix some app in the future.

Take a look at dlls/ddraw/tests/dsurface.c and dlls/ddraw/tests/visual.c. The 
best would be to write a test for the 2D blitting path in dsurface.c and a 
test for drawing with a color keyed 3D texture in visual.c