[PATCH vkd3d] vkd3d-shader/hlsl: Mark WriteToSubresource test as todo on NVIDIA.

[Giovanni Mascellani]

Similarly to ReadFromSubresource, WriteToSubresource is currently
implemented only for images with linear tiling, which NVIDIA drivers
currently do not support.

Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com>
---
 tests/d3d12.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/d3d12.c b/tests/d3d12.c
index 89b1f000..1fa017ab 100644
--- a/tests/d3d12.c
+++ b/tests/d3d12.c
@@ -32060,6 +32060,7 @@ static void test_read_write_subresource(void)
 
     /* NULL box */
     hr = ID3D12Resource_WriteToSubresource(src_texture, 0, NULL, dst_buffer, row_pitch, slice_pitch);
+    todo_if(is_nvidia_device(device))
     ok(hr == S_OK, "Got unexpected hr %#x.\n", hr);
 
     hr = ID3D12Resource_ReadFromSubresource(src_texture, dst_buffer, row_pitch, slice_pitch, 0, NULL);
@@ -32102,17 +32103,20 @@ static void test_read_write_subresource(void)
         if (i)
         {
             hr = ID3D12Resource_WriteToSubresource(src_texture, 0, NULL, zero_buffer, row_pitch, slice_pitch);
+            todo_if(is_nvidia_device(device))
             ok(hr == S_OK, "Got unexpected hr %#x.\n", hr);
 
             /* Write region 1 */
             set_box(&box, 0, 0, 0, 2, 2, 2);
             hr = ID3D12Resource_WriteToSubresource(src_texture, 0, &box, dst_buffer, row_pitch, slice_pitch);
+            todo_if(is_nvidia_device(device))
             ok(hr == S_OK, "Got unexpected hr %#x.\n", hr);
 
             /* Write region 2 */
             set_box(&box, 2, 2, 2, 11, 13, 17);
             hr = ID3D12Resource_WriteToSubresource(src_texture, 0, &box, &dst_buffer[2 * 128 * 100 + 2 * 128 + 2],
                     row_pitch, slice_pitch);
+            todo_if(is_nvidia_device(device))
             ok(hr == S_OK, "Got unexpected hr %#x.\n", hr);
         }
         else
@@ -32217,6 +32221,7 @@ static void test_read_write_subresource(void)
         if (got != expected)
             break;
     }
+    todo_if(is_nvidia_device(device))
     ok(got == expected, "Got unexpected value 0x%08x at (%u, %u, %u), expected 0x%08x.\n", got, x, y, z, expected);
     release_resource_readback(&rb);
 
-- 
2.33.0

[Henri Verbeet]

On Tue, 5 Oct 2021 at 15:47, Giovanni Mascellani
<gmascellani(a)codeweavers.com> wrote:
> Similarly to ReadFromSubresource, WriteToSubresource is currently
> implemented only for images with linear tiling, which NVIDIA drivers
> currently do not support.
>
> Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com>
> ---
>  tests/d3d12.c | 5 +++++
>  1 file changed, 5 insertions(+)

The patch is otherwise fine, but I think we'd want the subject prefix
to be "tests:".