Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics. (try 3)

[Alexandre Julliard]

Sam Edwards <cfsworks(a)gmail.com> writes:
> Content-wise, this is the same as try 2. However, there are two differences:
>
> 1. I merged the tests down into the same patch.
> 2. This won't crash anymore: see patch 1 in this series.

It still crashes:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff550f680 in get_glyph_outline (incoming_font=<optimized out>, glyph=<optimized out>, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:6389
6389	                                 ((unsigned int)src[hmul * x + rgb_interval * 2] <<  0) |
(gdb) bt
#0  0x00007ffff550f680 in get_glyph_outline (incoming_font=<optimized out>, glyph=<optimized out>, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:6389
#1  0x00007ffff550fd1e in freetype_GetGlyphOutline (dev=0x40df0, glyph=<optimized out>, format=<optimized out>, lpgm=0x22c9f0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:7133
#2  0x00007ffff54fcd84 in GetGlyphOutlineW (hdc=<optimized out>, uChar=103, fuFormat=17, lpgm=0x22c9f0, cbBuffer=288, lpBuffer=0x538c4, lpmat2=0x7ffff5535140) at ../../../wine/dlls/gdi32/font.c:2813
#3  0x00007ffff54c97b5 in render_string (hdc=0x490031, dib=<optimized out>, font=0x43cb0, x=95, y=11, flags=12288, str=0x51b70, count=13, dx=0x53470, clipped_rects=0x22cbb0, bounds=0x22cba0) at ../../../wine/dlls/gdi32/dibdrv/graphics.c:707

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics. (try 3)

[Sam Edwards]

On 04/30/2013 11:05 AM, Alexandre Julliard wrote:
> It still crashes:

Hmm... Guess I didn't fully understand the underlying problem. 
Fortunately, after enabling subpixel rendering on my system, the same 
crash now happens for me, so I can figure out exactly what's breaking.

I'll try to get try 4 sent in either today or tomorrow, but it depends 
how long it takes me to understand this bug (and any other impact it may 
have that we're not seeing) completely.

Thanks,
Sam