Re: comctl32: Fix invalid syntax.
18 hours passed, and it looks like Alexandre decided to ignore this...why? This fix is required for Wine to be built with VC2005/2008 (although Alexandre doesn't seem to care about it). On 2/6/08, Bang Jun-young <junyoung(a)mogua.com> wrote:
Any reason why this hasn't been committed?
"Bang Jun-young" <junyoung(a)mogua.com> writes:
18 hours passed, and it looks like Alexandre decided to ignore this...why?
This fix is required for Wine to be built with VC2005/2008 (although Alexandre doesn't seem to care about it).
There's no need to count the hours, or to ask every day, especially not with a mail to wine-patches. I have lots of pending patches from my vacation, I'll get to it eventually, and if I don't you should resubmit it after a week has passed. And if you want me to care about VC2005, maybe you should mention in your patch that this is the reason for your change, "fix invalid syntax" doesn't tell me anything. -- Alexandre Julliard julliard(a)winehq.org
On 2/7/08, Alexandre Julliard <julliard(a)winehq.org> wrote:
"Bang Jun-young" <junyoung(a)mogua.com> writes:
18 hours passed, and it looks like Alexandre decided to ignore this...why?
This fix is required for Wine to be built with VC2005/2008 (although Alexandre doesn't seem to care about it).
There's no need to count the hours, or to ask every day, especially not with a mail to wine-patches. I have lots of pending patches from my vacation, I'll get to it eventually, and if I don't you should resubmit it after a week has passed.
That's because you wanted yourself to be the only committer in the project. Why don't you give commit privilege to other Wine contributors as well?
And if you want me to care about VC2005, maybe you should mention in your patch that this is the reason for your change, "fix invalid syntax" doesn't tell me anything.
The patch is so obvious that I presumed you need no explanation.
Bang Jun-young wrote:
On 2/7/08, Alexandre Julliard <julliard(a)winehq.org> wrote:
"Bang Jun-young" <junyoung(a)mogua.com> writes:
18 hours passed, and it looks like Alexandre decided to ignore this...why?
This fix is required for Wine to be built with VC2005/2008 (although Alexandre doesn't seem to care about it). There's no need to count the hours, or to ask every day, especially not with a mail to wine-patches. I have lots of pending patches from my vacation, I'll get to it eventually, and if I don't you should resubmit it after a week has passed.
That's because you wanted yourself to be the only committer in the project. Why don't you give commit privilege to other Wine contributors as well? Huh? Why would you need that? Wine uses git, a distributed SCM. You are free to publish your own Wine tree without waiting for Alexandre.
People prefer to follow Alexandre's tree but nobody forces them to use it. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich
participants (3)
-
Alexandre Julliard -
Bang Jun-young -
Michael Stefaniuc