[PATCH 2/2] winhttp: Avoid double free on connection error.

[Hans Leidekker]

Reported by Stefan Dösinger.

Signed-off-by: Hans Leidekker <hans(a)codeweavers.com>
---
 dlls/winhttp/net.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c
index 25644a10be..c866c9b9fd 100644
--- a/dlls/winhttp/net.c
+++ b/dlls/winhttp/net.c
@@ -233,7 +233,8 @@ netconn_t *netconn_create( hostdata_t *host, const struct sockaddr_storage *sock
     if (!ret)
     {
         WARN("unable to connect to host (%u)\n", get_last_error());
-        netconn_close( conn );
+        closesocket( conn->socket );
+        heap_free( conn );
         return NULL;
     }
     return conn;
-- 
2.11.0

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=41224

Your paranoid android.


=== debian9 (build) ===
error: patch failed: dlls/winhttp/net.c:359
error: patch failed: dlls/winhttp/net.c:233
Task: Patch failed to apply