Re: msi: Do not return success on failure (spotted by clang)
9 May
2016
9 May
'16
3:18 a.m.
On Sun, 2016-05-08 at 18:31 +0300, Kirill Smirnov wrote:
Signed-off-by: Kirill K. Smirnov <kirill.k.smirnov(a)gmail.com> --- dlls/msi/where.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/msi/where.c b/dlls/msi/where.c index e3bc9b7..ddd8c07 100644 --- a/dlls/msi/where.c +++ b/dlls/msi/where.c @@ -593,7 +593,7 @@ static UINT WHERE_evaluate( MSIWHEREVIEW *wv, const UINT rows[],
default: ERR("Invalid expression type\n"); - break; + return ERROR_FUNCTION_FAILED; }
return ERROR_SUCCESS;
It doesn't apply here: $ patch -p1 --dry-run < 122148 checking file dlls/msi/where.c patch: **** malformed patch at line 16: UINT rows[], Looks like your mail client wrapped long lines.
3506
Age (days ago)
3506
Last active (days ago)
0 comments
1 participants
participants (1)
-
Hans Leidekker