Regression caused by "ntdll: Check file size when mapping image sections to avoid SIGBUS errors."

[Troy Rollo]

On Wed, 4 Jan 2006 08:21, Alexandre Julliard wrote:
> Module: wine
> Branch: refs/heads/master
> Commit: 67f29999a36ce3725a52b79ed618964244cc96ae

...
> status = STATUS_INVALID_IMAGE_FORMAT;  /* generic error */
> +    if (header_size > st.st_size) goto error;
>      if (map_file_into_view( view, fd, 0, header_size, 0, VPROT_COMMITTED |

...

This change prevents Wine from loading Win32 executables that are less than 
64K long. header_size is 65536, but st.st_size is less than that.
-- 
Troy Rollo - wine(a)troy.rollo.name

[Alexandre Julliard]

Troy Rollo <wine(a)troy.rollo.name> writes:
> On Wed, 4 Jan 2006 08:21, Alexandre Julliard wrote:
> > Module: wine
> > Branch: refs/heads/master
> > Commit: 67f29999a36ce3725a52b79ed618964244cc96ae
>
> ...
> > status = STATUS_INVALID_IMAGE_FORMAT;  /* generic error */
> > +    if (header_size > st.st_size) goto error;
> >      if (map_file_into_view( view, fd, 0, header_size, 0, VPROT_COMMITTED |
>
> ...
>
> This change prevents Wine from loading Win32 executables that are less than 
> 64K long. header_size is 65536, but st.st_size is less than that.

Why is header_size 65536 for you?  That looks way too much. Could you
please send me that binary?

-- 
Alexandre Julliard
julliard(a)winehq.org

[Troy Rollo]

On Wednesday 11 January 2006 20:55, Alexandre Julliard wrote:
> Why is header_size 65536 for you?  That looks way too much. Could you
> please send me that binary?

Attached.

[Alexandre Julliard]

Troy Rollo <wine(a)troy.rollo.name> writes:
> On Wednesday 11 January 2006 20:55, Alexandre Julliard wrote:
> > Why is header_size 65536 for you?  That looks way too much. Could you
> > please send me that binary?
>
> Attached.

Thanks; it's because the section alignment is set to 64k instead of 4k
for some reason. It should be fixed now.

-- 
Alexandre Julliard
julliard(a)winehq.org