Re: [PATCH 4/5] wined3d: Add texture flag for mipmap generation.

[Henri Verbeet]

On 20 September 2017 at 19:53, Matteo Bruni <mbruni(a)codeweavers.com> wrote:
> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com>
> ---
> Tests (later on in the patch series) show that calling GenerateMips()
> on a texture without the D3D11_RESOURCE_MISC_GENERATE_MIPS flag does
> nothing.  In theory, the whole check could be done on the d3d11 side
> but that turns out to be somewhat awkward, in practice, so I'm going
> to add a wined3d flag and pass it around instead.

In principle that's fine, but like this it's unused. (For what it's
worth, I don't necessarily think it needs to be used a lot initially.
Even if it's only used to print the FIXME or not in
wined3d_texture_generate_mipmaps() that would be a start.)

There's also the matter of how this relates to
WINED3DUSAGE_AUTOGENMIPMAP. This flag is for manual mipmap generation,
while WINED3DUSAGE_AUTOGENMIPMAP is for automatic mipmap generation,
but it's not pretty that one is a texture flag while the other is a
resource usage flag.