Re: [PATCH 1/2] kernel32: Don't print a FIXME for languages with ANSI codepage 0.

[Dmitry Timoshkov]

Michael Stefaniuc <mstefani(a)redhat.de> wrote:
> if (!(cp = get_lcid_codepage( locale )))
>      {
> -        FIXME("For locale %04x using current ANSI code page\n", locale);
> +        TRACE("No ANSI codepage for locale %04x. Using current ANSI code page\n", locale);
>          cp = GetACP();
>      }

A better changelog would probably sound like
"kernel32: Don't print a FIXME for unicode-only languages."

since ANSI code page 0 does not exist.

-- 
Dmitry.

[PATCH 1/2] kernel32: Don't print a FIXME for languages with ANSI codepage 0.

[Michael Stefaniuc]

On 11/26/2010 07:50 AM, Dmitry Timoshkov wrote:
> Michael Stefaniuc<mstefani(a)redhat.de>  wrote:
> > if (!(cp = get_lcid_codepage( locale )))
> >       {
> > -        FIXME("For locale %04x using current ANSI code page\n", locale);
> > +        TRACE("No ANSI codepage for locale %04x. Using current ANSI code page\n", locale);
> >           cp = GetACP();
> >       }
>
> A better changelog would probably sound like
> "kernel32: Don't print a FIXME for unicode-only languages."
>
> since ANSI code page 0 does not exist.
> Heh, that patch is already rejected.

The proper fix is of course "Don't use ANSI functions for unicode-only 
languages" (hint: clock doesn't use any ;) . So if somebody is up for 
the challenge this is a nice little code cleanup :)

bye
	michael

[PATCH 1/2] kernel32: Don't print a FIXME for languages with ANSI codepage 0.

[Dmitry Timoshkov]

Michael Stefaniuc <mstefani(a)redhat.com> wrote:
> The proper fix is of course "Don't use ANSI functions for unicode-only 
> languages" (hint: clock doesn't use any ;) . So if somebody is up for 
> the challenge this is a nice little code cleanup :)

It means that some parts of Wine are still using A versions of APIs
internally, should be pretty easy to figure out.

-- 
Dmitry.