Command Stream Update
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I have published an update to the command stream patches from September. The code is available on Github at https://github.com/stefand/wine (direct git url at https://github.com/stefand/wine). A small change summary: *) Tons of bug fixes. *) Dynamic surface maps. This improves World of Warcraft and many other games. *) The code avoids acquiring a GL context on the main thread, with few exceptions. This improves stability on all drivers, especially on fglrx. *) This version essentially matches the command stream code we shipped in CrossOver 13, just applied on top of Wine. *) The Wine version this tree is based on is the git head from this evening, 460991a8. As with the last version you have to set HKEY_CURRENT_USER/Software/Wine/Direct3D/CSMT="enabled" to use it. You should disable StrictDrawOrdering because it is no longer needed with CSMT on. I plan to push updates to this repository at irregular intervals. I probably won't send an announcement to wine-devel every time I do this. I also don't promise any schedule - it mostly depends on how busy I am with other work and how difficult the rebases are. Enjoy, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSzHIsAAoJEN0/YqbEcdMw10wQAIBZ1LuNK4By0WLZzujwww3Z mZjd/kgux13THVtTzVoxVL38nzhOxIuGV0B5P6yoXJlKpxILSCdjr208EWMf+qo7 j4m3DGibrSrjPOCog4hXQeMrn2YjHC2BnFtDIiCYKq33ZPjJ60mSKEkpOzzbeEa8 7C7l9Y+mGKHQl6WViUp7HMoxFo3irZ1DCxRiDiOcFXdQhOZEpuuClB+vabUh15OH 3iNQdAwIiH9YZk9ir7nF5zcbnnLJGNjKNNUPEPu91P1PQ9LdM3zNqz7jU2Klo0Kl 7ZA+O6JVHSuWw04w1Lz6UM7Exu1dY6hRL9BfZQxodBOXtC0NwqIMbeW0bKn1VMEL cF4a+3sqGTJhni0dITEP1BzqmZH3sqYBPuOCb244+UOYwUjLTtx2QcASE3khb8D8 XVry6zrGJl1t1WzwPC/SK6/IOWHhvcznX+JeoYQiNIfOuFUsoVjKcswDxDLLi/+0 qUSpdWvI9fWy/udpaJoemspX0fjvNud6TcdLA/hHvfpoa6+fbHEJV+EC0M6PHFw8 RZ6Hi3VTlg0FBKYqowarqjjYNAxYWecTo9LKjMYTzFVpH4fTKcZUOpMdV+A2sRvv F0Hy0beXyih+Q03HwKmIbWQqWME1Fr62iCa88uO6leT4tPJ5SG3oZ2Reb2zmvFJq QbfNO3JMTqTqrXyUcsQj =dysQ -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-07 22:31, schrieb Stefan Dösinger:
direct git url at https://github.com/stefand/wine. Copypaste fail. This should be https://github.com/stefand/wine.git . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSzHKpAAoJEN0/YqbEcdMw3qUP/jO14JuRhgMsnbZFGaLKTuhn YFoc4CVySVx9i4d0xN364U5smQjdgo9h4ihITJqqKNZYK/MBjvHOVMa8tDgLmrxe DRHiLJ1XxjWC1K6ajoSZ54yvdqbIoaRyZl46n9mI0KP7I8XSC013ZpqSAQj5sHHW 5jz6vkMeluu+TtX0yuzNngakb/O4BQ+V+SvDex3Gqqsl70GinNFw7bTspHMsafQv zkJSSJbCeo/qPjDonwBzQ4OKUQbkGeBiUTXCNKjfH/EoyOHJNNKsssSRAC6sS8U2 gSbk8aORZu1Zss/5Bcjbw0M9PffWS7RtqGTYrOgqepulhGxflnpPIlz6Mju/2G03 DDauuaqYIMxeJSSmYrO4GNdHuIQ3DwQvImEAWdcj9skoeI+/PGb59oPFnOaz5h44 juiFhWgb85+d1c3JcuPdsSriImrs4CfXilBeLNXPkD4DI+CSdR9hQKoKhrNjpXtj hlnaB5So6TgTC83lLlBaiGrXJhdpeVg6HnkcOkexUyKR9V3Vqg1JArac/YqyYd+r EIy6xP8nO6GA0zfGGFBQlkKbjoJK5iUSGHcNSFgvq2+UPx76tuW7JnJJFuQ0bXnV TVDZiivzqgBnnNUziB8HE9maxq0YP8Uh3WiO9YA0lXDvt7FqN1xgvqubWRMFrG2h RChsMt0OBoYPHRXMnUO6 =3nxR -----END PGP SIGNATURE-----
Still a massive perf loss on WoW when outdoors. This spams: err:d3d:wined3d_debug_callback 0x7f4c0: "GL_INVALID_VALUE error generated. Point size must not be negative.". err:d3d:state_pscale >>>>>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glPointSize(...); @ ../../../wine-multimedia/dlls/wined3d/state.c / 1572 J. Leclanche On Tue, Jan 7, 2014 at 9:33 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-01-07 22:31, schrieb Stefan Dösinger:
direct git url at https://github.com/stefand/wine. Copypaste fail. This should be https://github.com/stefand/wine.git . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSzHKpAAoJEN0/YqbEcdMw3qUP/jO14JuRhgMsnbZFGaLKTuhn YFoc4CVySVx9i4d0xN364U5smQjdgo9h4ihITJqqKNZYK/MBjvHOVMa8tDgLmrxe DRHiLJ1XxjWC1K6ajoSZ54yvdqbIoaRyZl46n9mI0KP7I8XSC013ZpqSAQj5sHHW 5jz6vkMeluu+TtX0yuzNngakb/O4BQ+V+SvDex3Gqqsl70GinNFw7bTspHMsafQv zkJSSJbCeo/qPjDonwBzQ4OKUQbkGeBiUTXCNKjfH/EoyOHJNNKsssSRAC6sS8U2 gSbk8aORZu1Zss/5Bcjbw0M9PffWS7RtqGTYrOgqepulhGxflnpPIlz6Mju/2G03 DDauuaqYIMxeJSSmYrO4GNdHuIQ3DwQvImEAWdcj9skoeI+/PGb59oPFnOaz5h44 juiFhWgb85+d1c3JcuPdsSriImrs4CfXilBeLNXPkD4DI+CSdR9hQKoKhrNjpXtj hlnaB5So6TgTC83lLlBaiGrXJhdpeVg6HnkcOkexUyKR9V3Vqg1JArac/YqyYd+r EIy6xP8nO6GA0zfGGFBQlkKbjoJK5iUSGHcNSFgvq2+UPx76tuW7JnJJFuQ0bXnV TVDZiivzqgBnnNUziB8HE9maxq0YP8Uh3WiO9YA0lXDvt7FqN1xgvqubWRMFrG2h RChsMt0OBoYPHRXMnUO6 =3nxR -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-08 20:03, schrieb Jerome Leclanche:
Still a massive perf loss on WoW when outdoors. This spams:
err:d3d:wined3d_debug_callback 0x7f4c0: "GL_INVALID_VALUE error generated. Point size must not be negative.". err:d3d:state_pscale
>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glPointSize(...); @ ../../../wine-multimedia/dlls/wined3d/state.c / 1572 J. Leclanche At which settings does this happen? Which driver? Does it happen with CSMT=disabled? Do the ERRs show up with plain Wine?
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSznkKAAoJEN0/YqbEcdMw72gP/2vnKMiBsRzG7vLcV2BGV3hV 95v/hu9yK8+Fw3h8h/AFvMNScRZL9uxGibxPSMNBDQ0pbaYH5y1VN8+GQEdDcOPV bmjjKrwuGAU3cJ3Sn0eDFloTqAy+Lip/+TrPCe+Ga7zwjuVBELon790bfRuUy6yZ /o+1L9wZoDvqffj10JIqGnjX6ibPQPQkeb5izc+Y2ju5o7xedOd85p4Wvtm8iSZV qAmKQF+2p1G+Hz7LikUMCYI0Cn3qRK7dap1twSczJ4bWdC4aU5+QL/AvJ4ebvsJx aIPeFJfSl6r3upLXxMUgT1FfCvIGi3ioGPUUukpCOsnw7A1Kza3I4S44HfbOEl/y sO6FVhSjNsia4PqgaF9iRbaof02qD3Pb7mjSuIzTS4qPr1vBAuJGBqQhWD1TWfTw JvQa5Pc+urJzJ2pW52/ObRsEzNS9rktmsePGK/2g88TAKkP8G54Ra0qZtq9X1VCd ylI5HxVdhNeIR/NFVqegfrX/UtmHxU5LLBOZvX0RbESnV+0shR5JFOsi/PCU4zPw bT/wAP+AkWcfVB3wsji/J952V8fvymd3h2PCFtLkXWloRBg+XNFSxDkgPmjdIBCB 8gDYqS+MbpS0DwVuNdEeto+OcSgT05YKz1SMWOQRXOp3npAbibZzNOlCMCZjCArr 77LL7H0h7XKg58uC4eHo =yb0B -----END PGP SIGNATURE-----
The issue doesn't show up with plain Wine, only with your patches applied. It happens with both CMST=disabled and enabled. This seems to be the same issue we were hitting last time I tested your CS patches, on IRC. The problem only seems to show up outdoors, not indoors. nvidia 331.20-3 J. Leclanche On Thu, Jan 9, 2014 at 10:25 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-01-08 20:03, schrieb Jerome Leclanche:
Still a massive perf loss on WoW when outdoors. This spams:
err:d3d:wined3d_debug_callback 0x7f4c0: "GL_INVALID_VALUE error generated. Point size must not be negative.". err:d3d:state_pscale
>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glPointSize(...); @ ../../../wine-multimedia/dlls/wined3d/state.c / 1572 J. Leclanche At which settings does this happen? Which driver? Does it happen with CSMT=disabled? Do the ERRs show up with plain Wine?
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSznkKAAoJEN0/YqbEcdMw72gP/2vnKMiBsRzG7vLcV2BGV3hV 95v/hu9yK8+Fw3h8h/AFvMNScRZL9uxGibxPSMNBDQ0pbaYH5y1VN8+GQEdDcOPV bmjjKrwuGAU3cJ3Sn0eDFloTqAy+Lip/+TrPCe+Ga7zwjuVBELon790bfRuUy6yZ /o+1L9wZoDvqffj10JIqGnjX6ibPQPQkeb5izc+Y2ju5o7xedOd85p4Wvtm8iSZV qAmKQF+2p1G+Hz7LikUMCYI0Cn3qRK7dap1twSczJ4bWdC4aU5+QL/AvJ4ebvsJx aIPeFJfSl6r3upLXxMUgT1FfCvIGi3ioGPUUukpCOsnw7A1Kza3I4S44HfbOEl/y sO6FVhSjNsia4PqgaF9iRbaof02qD3Pb7mjSuIzTS4qPr1vBAuJGBqQhWD1TWfTw JvQa5Pc+urJzJ2pW52/ObRsEzNS9rktmsePGK/2g88TAKkP8G54Ra0qZtq9X1VCd ylI5HxVdhNeIR/NFVqegfrX/UtmHxU5LLBOZvX0RbESnV+0shR5JFOsi/PCU4zPw bT/wAP+AkWcfVB3wsji/J952V8fvymd3h2PCFtLkXWloRBg+XNFSxDkgPmjdIBCB 8gDYqS+MbpS0DwVuNdEeto+OcSgT05YKz1SMWOQRXOp3npAbibZzNOlCMCZjCArr 77LL7H0h7XKg58uC4eHo =yb0B -----END PGP SIGNATURE-----
On Thu, 9 Jan 2014 18:48:34 +0000, Jerome Leclanche <adys.wh(a)gmail.com> wrote:
The issue doesn't show up with plain Wine, only with your patches applied. It happens with both CMST=disabled and enabled.
This seems to be the same issue we were hitting last time I tested your CS patches, on IRC. The problem only seems to show up outdoors, not indoors. nvidia 331.20-3
FWIW, I cannot (with a quick try in orgrimar) reproduce this issue with Stefan's patches. I do see a +10 to +15 fps increase when enabling CMST with identical settings, with DX9 renderer. nvidia 319.76, geforce gtx 650 What area do you get this problem in ? What renderer are you using ? If needed, I think I can post extracts from my config file. Regards, -- Vincent Pelletier
On Thu, Jan 9, 2014 at 8:06 PM, Vincent Pelletier <plr.vincent(a)gmail.com> wrote:
On Thu, 9 Jan 2014 18:48:34 +0000, Jerome Leclanche <adys.wh(a)gmail.com> wrote:
The issue doesn't show up with plain Wine, only with your patches applied. It happens with both CMST=disabled and enabled.
This seems to be the same issue we were hitting last time I tested your CS patches, on IRC. The problem only seems to show up outdoors, not indoors. nvidia 331.20-3
FWIW, I cannot (with a quick try in orgrimar) reproduce this issue with Stefan's patches. I do see a +10 to +15 fps increase when enabling CMST with identical settings, with DX9 renderer.
nvidia 319.76, geforce gtx 650
What area do you get this problem in ? What renderer are you using ? If needed, I think I can post extracts from my config file.
Regards, -- Vincent Pelletier
Interesting. I get it pretty much everywhere, but it's easiest to test in towns. Ping me on irc (jleclanche) and I can do some tests. J. Leclanche
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-09 22:26, schrieb Jerome Leclanche:
Interesting. I get it pretty much everywhere, but it's easiest to test in towns. Ping me on irc (jleclanche) and I can do some tests. A regression test with CSMT=disabled would be helpful. Every single revision should work with CSMT=disabled, in theory.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSz8S4AAoJEN0/YqbEcdMwpu0P/1Bafnt4HEb6xJMVGw+i/tFa 2k7fhO/PSwdL5LUspaUkMFLRyS330qraM+W8Z8jdkNdogXS7QVRe96LHMHV5cJ6n 8jfpdYKg9YfscG6dd1783xO1FI+AQfcPQ1jlrM62gmOQQwbCDqOmzglJU61rP53B wZWRLujCasHTTdDcmHzQHiDzeidSevkhFhOiICBXGq5GFGARcWPxtEr5Cv65GqIb cQ3UegWh0Evd7AMm0uWd9fdhQK/r3ymYwdEDui15zcMsuA8N6q0JWW+Psc3aBYOx gQ8EHxosXS2hp4+Gfnw7BFuoi329ZTGvghgnPWH7MEIopZk0S/3nUjxbcyN5voIr Uv9cgSaFfmesTMfEHuIumPFAkqmeC9I+W+szn3OQOE+KEWMgpnnCXMZocVRF60U3 d44ikvm3QE4rAadzRl8LodoOc4DYqfMJcJl6GyM77XBnghyprCpD4XBJv9X0AlmI hq2wFBsn+FkJZ8uasykMcjWbY4t+MY/1EEUceO1bqxfG2JXG8Sz3BOGsLMRGGStP 7GqIVrWRQna8B+U/UeAw11be7P3jtevNBAl6lAIxtgO0k7jIDGfGNVEVTUdxcqmZ rYeQq0k/O5XkDCd1/x/iPRlvDJaMQE2Af07LzUuiVmgi0YX3gRm3godSFCJT9wFT OUaF+uxUHEc4L3VblceZ =sLVQ -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, Please disregard what I said on IRC. The errs are indeed present in plain wine, however the FPS drop is indeed due to the command stream patches. Regression test came up with this: fa64ebc444cc7682d7a1303e0fb0333810b6f4e0 is the first bad commit commit fa64ebc444cc7682d7a1303e0fb0333810b6f4e0 Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Thu Aug 29 17:35:53 2013 +0200 wined3d: Create buffers before mapping them. :040000 040000 af758145359faf825158cbb95923abb62ae36e26 3b62754350347894c3fae4a8c554423b5792fbb5 M dlls Filed a bug about the errs: https://bugs.winehq.org/show_bug.cgi?id=35363 J. Leclanche On Fri, Jan 10, 2014 at 10:00 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-01-09 22:26, schrieb Jerome Leclanche:
Interesting. I get it pretty much everywhere, but it's easiest to test in towns. Ping me on irc (jleclanche) and I can do some tests. A regression test with CSMT=disabled would be helpful. Every single revision should work with CSMT=disabled, in theory.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSz8S4AAoJEN0/YqbEcdMwpu0P/1Bafnt4HEb6xJMVGw+i/tFa 2k7fhO/PSwdL5LUspaUkMFLRyS330qraM+W8Z8jdkNdogXS7QVRe96LHMHV5cJ6n 8jfpdYKg9YfscG6dd1783xO1FI+AQfcPQ1jlrM62gmOQQwbCDqOmzglJU61rP53B wZWRLujCasHTTdDcmHzQHiDzeidSevkhFhOiICBXGq5GFGARcWPxtEr5Cv65GqIb cQ3UegWh0Evd7AMm0uWd9fdhQK/r3ymYwdEDui15zcMsuA8N6q0JWW+Psc3aBYOx gQ8EHxosXS2hp4+Gfnw7BFuoi329ZTGvghgnPWH7MEIopZk0S/3nUjxbcyN5voIr Uv9cgSaFfmesTMfEHuIumPFAkqmeC9I+W+szn3OQOE+KEWMgpnnCXMZocVRF60U3 d44ikvm3QE4rAadzRl8LodoOc4DYqfMJcJl6GyM77XBnghyprCpD4XBJv9X0AlmI hq2wFBsn+FkJZ8uasykMcjWbY4t+MY/1EEUceO1bqxfG2JXG8Sz3BOGsLMRGGStP 7GqIVrWRQna8B+U/UeAw11be7P3jtevNBAl6lAIxtgO0k7jIDGfGNVEVTUdxcqmZ rYeQq0k/O5XkDCd1/x/iPRlvDJaMQE2Af07LzUuiVmgi0YX3gRm3godSFCJT9wFT OUaF+uxUHEc4L3VblceZ =sLVQ -----END PGP SIGNATURE----- -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux)
iQJ8BAEBCgBmBQJS0IUoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxNjk3MDRDNkZCNDkwQzY4OTJDN0YyM0Mz N0UwQUYxRkRBNDhGMzczAAoJEDfgrx/aSPNzDFIP/2aiSuXhDnNdnWLwrIyBtm3m h93u8qU3O3Gm1TfpNRHRU/8lDhRrZXJg/6Kyzd+DYFO6PdFye+bl7uPJKVeVzQJU w/uThphlKJJh216lCw3HthfPhspyaO7NCCKOnXjwshiNtySiBb0MD1MyBQUAIGwM c7mtbUUAWmGBkIKpk72GIFNQmqYMUC3J4o0jC9OWa79WEnnHbt2piUiuOwu5Kf/Z w9e4yBHDoRNAhI7d6o9S5H5d55ONzueNVuwr1Vs5IiSlRNRe56LLRrLA7vooKRMF DQPxXK8c2AyqEAsWVlChsk8sJWszxVWafhrYKYoyqLRkokVkQcmaCCK94RifpE8c iZ/fRvsNiZrNBb17xFFAsycrpp/fJIOwjuGtVpET8J7STVUiLXLFAgMmvN0P46bo 1f6QQ0e/7LsOxAt5BbZHAODOWmL6Mpon3tmrSKDNXOSS9QSr7WoJej04dQr+EXBU Nzjp/lmMIav88H2HYoKeKYx0TX4+iBPSO4ELSRzcCl4SqipHF6QJWKLCZKS29iF7 IQh3ly0Qeqof23V3f2o8pyrcsMSYdki3Hzj9Wcf1KSMSYKyyLYem0QQwKBbOISMX yXmOfmZJ82x7BHbRaJMBEP3Pu4rOATTdTB/i2CO8rHymqE9ONgbSx9+KFH97mJSp 0EVEjHjV2T9Eyiwzq+G9 =xcsK -----END PGP SIGNATURE-----
participants (3)
-
Jerome Leclanche -
Stefan Dösinger -
Vincent Pelletier