Re: [PATCH 2/10] dinput: [joystick_linux] Copy and modify default data format.

[Alexandre Julliard]

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes:
> @@ -610,6 +632,8 @@ static ULONG WINAPI JoystickAImpl_Releas
>      HeapFree(GetProcessHeap(), 0, This->props);
>
> /* release the data transform filter */
> +    HeapFree(GetProcessHeap(), 0, (LPVOID)This->base.data_format.wine_df->rgodf);
> +    HeapFree(GetProcessHeap(), 0, (LPVOID)This->base.data_format.wine_df);

Please don't add more cast-qual warnings, we are trying to get rid of
them.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 2/10] dinput: [joystick_linux] Copy and modify default data format.

[Vitaliy Margolen]

Alexandre Julliard wrote:
> Vitaliy Margolen <wine-patches(a)kievinfo.com> writes:
> > @@ -610,6 +632,8 @@ static ULONG WINAPI JoystickAImpl_Releas
> >      HeapFree(GetProcessHeap(), 0, This->props);
> >
> > /* release the data transform filter */
> > +    HeapFree(GetProcessHeap(), 0, (LPVOID)This->base.data_format.wine_df->rgodf);
> > +    HeapFree(GetProcessHeap(), 0, (LPVOID)This->base.data_format.wine_df);
>
> Please don't add more cast-qual warnings, we are trying to get rid of
> them.

Sorry, I forgot about this completely. I was getting errors without
cast. And I needed to keep wine_df const so other places won't complain.
Now it cant be fixed properly making wine_df not const.

Vitaliy.