multiple constant definitions

[Warren Turkal]

wt(a)braindead:~/src/wine/wine/include$ grep -ri 'c0000005' *
ntstatus.h:#define STATUS_ACCESS_VIOLATION          0xC0000005
winnt.h:#define STATUS_ACCESS_VIOLATION          0xC0000005

I found this while searching for the cause of Empire Earth to not work.
These are defined in multiple places. Would it not be better to just
include ntstatus.h in winnt.h?

wt
-- 
Warren Turkal
President, GOLUM, Inc.
http://www.golum.org

[Steven Edwards]

Hello Warren,

--- Warren Turkal <wt(a)midsouth.rr.com> wrote:
> wt(a)braindead:~/src/wine/wine/include$ grep -ri 'c0000005' *
> ntstatus.h:#define STATUS_ACCESS_VIOLATION          0xC0000005
> winnt.h:#define STATUS_ACCESS_VIOLATION          0xC0000005
>
> I found this while searching for the cause of Empire Earth to not
> work.
> These are defined in multiple places. Would it not be better to just
> include ntstatus.h in winnt.h?

Grep the Microsoft PSDK headers and see if they duplicate the constant.
If they do then we better leave it to be compatible with exiting source
code.

Thanks
Steven


__________________________________
Do you Yahoo!?
Yahoo! Finance Tax Center - File online. File on time.
http://taxes.yahoo.com/filing.html

[Alexandre Julliard]

Warren Turkal <wt(a)midsouth.rr.com> writes:
> wt(a)braindead:~/src/wine/wine/include$ grep -ri 'c0000005' *
> ntstatus.h:#define STATUS_ACCESS_VIOLATION          0xC0000005
> winnt.h:#define STATUS_ACCESS_VIOLATION          0xC0000005
>
> I found this while searching for the cause of Empire Earth to not work.
> These are defined in multiple places. Would it not be better to just
> include ntstatus.h in winnt.h?

No, Windows doesn't do that so we shouldn't either.

-- 
Alexandre Julliard
julliard(a)winehq.org

[Eric Pouech]

Alexandre Julliard a écrit :
> Warren Turkal <wt(a)midsouth.rr.com> writes:
> > wt(a)braindead:~/src/wine/wine/include$ grep -ri 'c0000005' *
> > ntstatus.h:#define STATUS_ACCESS_VIOLATION          0xC0000005
> > winnt.h:#define STATUS_ACCESS_VIOLATION          0xC0000005
> >
> > I found this while searching for the cause of Empire Earth to not work.
> > These are defined in multiple places. Would it not be better to just
> > include ntstatus.h in winnt.h?
>
> No, Windows doesn't do that so we shouldn't either.

sdk (tagged 2003-02) does it that way (constant is defined in both files)
A+

[Alexandre Julliard]

Eric Pouech <pouech-eric(a)wanadoo.fr> writes:
> Alexandre Julliard a écrit :
> > Warren Turkal <wt(a)midsouth.rr.com> writes:
> > > I found this while searching for the cause of Empire Earth to not work.
> > > These are defined in multiple places. Would it not be better to just
> > > include ntstatus.h in winnt.h?
> > > No, Windows doesn't do that so we shouldn't either.
>
> sdk (tagged 2003-02) does it that way (constant is defined in both files)

Yes that's what I meant, since the constants are duplicated on Windows
too we shouldn't include ntstatus.h from winnt.h.

-- 
Alexandre Julliard
julliard(a)winehq.org