Re: comctl32/tests: Fix couple of metrics tests that fail on some systems
Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
+ /* estimate using stock font metrics */ + hdc = GetDC(0); + hOldFont = SelectObject(hdc, GetStockObject (SYSTEM_FONT)); + GetTextMetricsA(hdc, &tm); + SelectObject(hdc, hOldFont); + ReleaseDC(0, hdc);
Probably DEFAULT_GUI_FONT should be used instead of SYSTEM, you really don't want to see SYSTEM_FONT on the screen, or just use its metrics. -- Dmitry.
On 03/31/2015 11:05 AM, Dmitry Timoshkov wrote:
Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
+ /* estimate using stock font metrics */ + hdc = GetDC(0); + hOldFont = SelectObject(hdc, GetStockObject (SYSTEM_FONT)); + GetTextMetricsA(hdc, &tm); + SelectObject(hdc, hOldFont); + ReleaseDC(0, hdc);
Probably DEFAULT_GUI_FONT should be used instead of SYSTEM, you really don't want to see SYSTEM_FONT on the screen, or just use its metrics.
Probably. I used what header code uses currently.
participants (2)
-
Dmitry Timoshkov -
Nikolay Sivov