Re: dlls/msvcrt: process.c (msvcrt-popen-1)

[Jaco Greeff]

On 01 Nov 2002 08:40:20 -0800, Alexandre Julliard <julliard(a)winehq.com> wrote :
> No, it's wrong. You should be using the Windows API (CreateProcess
> etc.) not the Unix popen(). Then you can build a proper MSVCRT_FILE.

Sorry, I had a few beers tonight ;) Ok, I just remembered what my concerns
were about using CreateProcess initially when I looked at MSDN:

CreateProcess executes a Windows executable with parameters, whereas _popen
executes as shell, ie. you can do stuff like _popen("dir/w") which will
return an open file in which you can read the directory contents from. In
essence under Windows, this gets executed at "cmd.exe /C dir/w". 

Now using CreatePorcess we can potentially do the same, provided that the
executable (command interpreter) resides in your path. From MSDN:

"The string can specify the full path and file name of the module to execute
or it can specify a partial name. In the case of a partial name, the
function uses the current drive and current directory to complete the
specification."

Now wera are faced with a problem in that wcmd is not a pure Windows
application and it doesn't reside in your Windows filesystem, rather it is
in your *nix path. 

In the case of _popen, a file-handle is returned which allows you to either
read or write to the application unsing the normal fwrite/fprintf/etc.
commands. CreateProcess has an information structure containing the
following information:

typedef struct _PROCESS_INFORMATION {
  HANDLE hProcess;
  HANDLE hThread;
  DWORD dwProcessId;
  DWORD dwThreadId;
} PROCESS_INFORMATION;

I don't see any clear way of doing,

1. Converting the above structure into something usable, eg. MSVCRT_FILE
2. Actually allowing us to read or write to the application

Potentially the magic lies in the current Wine CreateProcess implementation,
I'll have a look at it. Is doing this really feasable using the
CreateProcess family? In essence a HANDLE will map back to an fd with the
wine implementation (rather we can get an fd for a HANDLE), but can this be
used to read/write to the process? The first obstacle however, will be in
having a clean way to get wcmd going if it doesn't reside in C:\. Maybe it
should be there and should be installed like notepad.exe for example?

Some questions, and yes I'm slow tonight... :) I think that just by typing
this some concerns have been aleviated so excuse my rumblings but just check
the logic.

Greetings,
Jaco

dlls/msvcrt: process.c (msvcrt-popen-1)

[Francois Gouget]

On 1 Nov 2002, Jaco Greeff wrote:
[...]
> Now wera are faced with a problem in that wcmd is not a pure Windows
> application and it doesn't reside in your Windows filesystem, rather it is
> in your *nix path.

Try c:\Windows\System\wcmd.exe and I think you will find that it works.


-- 
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
    I haven't lost my mind, it's backed up on tape around here somewhere...

dlls/msvcrt: process.c (msvcrt-popen-1)

[Uwe Bonnes]

> > > > > "Francois" == Francois Gouget <fgouget(a)free.fr> writes:

Francois> On 1 Nov 2002, Jaco Greeff wrote: [...]
    >> Now wera are faced with a problem in that wcmd is not a pure Windows
    >> application and it doesn't reside in your Windows filesystem, rather
    >> it is in your *nix path.

    Francois> Try c:\Windows\System\wcmd.exe and I think you will find that
    Francois> it works.


Giving a fully qualified patch is probably bad advice here. Try "wcmd.exe"
only and have cmd.exe.so in wine's program directory. Wine sets on startup
WINEDLLPATH to "$topdir/dlls:$topdir/programs" and wineapploader there
should manage to start the application.

Probably Alexandre knows more.

Bye

-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------

dlls/msvcrt: process.c (msvcrt-popen-1)

[Francois Gouget]

On Fri, 1 Nov 2002, Uwe Bonnes wrote:
[...]
> Giving a fully qualified patch is probably bad advice here. Try "wcmd.exe"
> only and have cmd.exe.so in wine's program directory.

Actually, using COMSPEC or something like that might be even better.
The exact behavior has to be checked on Windows though.

-- 
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
     We are Pentium of Borg. You will be approximated. Division is futile.

dlls/msvcrt: process.c (msvcrt-popen-1)

[Dimitrie O. Paun]

On November 1, 2002 02:50 pm, Uwe Bonnes wrote:
> Probably Alexandre knows more.

Well, yeah, he always does! :)

-- 
Dimi.