sample msxml3 implementation

[Vijay Kiran Kamuju]

Hi,

I thought i have some suggestions in implementing the msxml3.dll

I am sending an old sample stub implemenation (incomplete).

I am rewriting the msxml3.dll

need some suggestions.

Thanks,
Vijay

[Mike McCormack]

Vijay Kiran Kamuju wrote:
> I thought i have some suggestions in implementing the msxml3.dll
> I am sending an old sample stub implemenation (incomplete).
> I am rewriting the msxml3.dll
> need some suggestions.

Some suggestions:

* get rid of the remaining C++ stuff in Makefile.in
* add an LGPL copyright header to the .c and .h files
* there's no need to print both the iface and This pointers in your 
TRACEs, as they'll be the same.

Mike

[Vijay Kiran Kamuju]

Sending with the changes.
please also check the msxml.idl and what more iids do i have to check
in the IXMLDocument_QueryInterface function
how to implement the 
HRESULT XMLDocument_create(IUnknown *pUnkOuter, LPVOID *ppObj); 

Thanks,
Vijay Kiran Kamuju

On 7/5/05, Mike McCormack <mike(a)codeweavers.com> wrote:
> Vijay Kiran Kamuju wrote:
> > I thought i have some suggestions in implementing the msxml3.dll
> > I am sending an old sample stub implemenation (incomplete).
> > I am rewriting the msxml3.dll
> > need some suggestions.
>
> Some suggestions:
>
> * get rid of the remaining C++ stuff in Makefile.in
> * add an LGPL copyright header to the .c and .h files
> * there's no need to print both the iface and This pointers in your
> TRACEs, as they'll be the same.
>
> Mike

[Vijay Kiran Kamuju]

Hi,

I'll working on after some time, my harddisk died on me, developed too
many bad sectors.
I'm trying to replace it, as it is still under warranty.
I'll sending a new copy as soon as i get my replacement harddisk.
By the way please send some suggestions how to implement the
XMLDocument_create and IXMLDocument_QueryInterface correctly.
I am using IXMLDocument as an example. 

Thanks,
Vijay
On 7/5/05, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> Sending with the changes.
> please also check the msxml.idl and what more iids do i have to check
> in the IXMLDocument_QueryInterface function
> how to implement the
> HRESULT XMLDocument_create(IUnknown *pUnkOuter, LPVOID *ppObj);
>
> Thanks,
> Vijay Kiran Kamuju
>
> On 7/5/05, Mike McCormack <mike(a)codeweavers.com> wrote:
> > Vijay Kiran Kamuju wrote:
> > > I thought i have some suggestions in implementing the msxml3.dll
> > > I am sending an old sample stub implemenation (incomplete).
> > > I am rewriting the msxml3.dll
> > > need some suggestions.
> >
> > Some suggestions:
> >
> > * get rid of the remaining C++ stuff in Makefile.in
> > * add an LGPL copyright header to the .c and .h files
> > * there's no need to print both the iface and This pointers in your
> > TRACEs, as they'll be the same.
> >
> > Mike