W-related helper functions for our tests
Hi, I was wondering if it would make sense to introduce several helper functions that could be used by all our tests. The main ones needed are the ones to cope with Win9x missing several W-functions. Another one used quite often in the tests is something like wine_dbgstr_w. Yet another one compares a W with an A-string. Ideas, remarks, suggestions? -- Cheers, Paul.
On Fr, 2009-06-19 at 12:44 +0200, Paul Vriens wrote:
I was wondering if it would make sense to introduce several helper functions that could be used by all our tests.
The main ones needed are the ones to cope with Win9x missing several W-functions.
Another one used quite often in the tests is something like wine_dbgstr_w.
Yet another one compares a W with an A-string.
Ideas, remarks, suggestions?
+1 debugstr_w is used often. With lstrcpyW, the results can be stored in UNICODE without loosing informations (CP_ACP) / without stumble over unsupported Codepages (CP_UTF8) -- By by ... Detlef
On Fri, 19 Jun 2009, Paul Vriens wrote:
Hi,
I was wondering if it would make sense to introduce several helper functions that could be used by all our tests.
The main ones needed are the ones to cope with Win9x missing several W-functions.
Another one used quite often in the tests is something like wine_dbgstr_w. [...]
A goal to keep in mind is that the conformance tests must be as independent from Wine as possible. This means that, except for wine/test.h of course, one should restrain from depending on Wine-specific headers. So if we add additional helper functions this essentially means they should be defined inwine/test.h. Also I feel it would be nice to keep the tests independent from msvcrt, especially on the Wine side (this to keep tests of low-level libraries from depending on high-level libraries, i.e. msvcrt). But maybe not everyone feels that way. That would mean we cannot depend on "%S" (unless one of the lower level Wine libraries (crtdll?) supports something like it too). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A particle is an irreducible representation of the Poincaré Group - Eugene Wigner
Francois Gouget wrote:
On Fri, 19 Jun 2009, Paul Vriens wrote:
Hi,
I was wondering if it would make sense to introduce several helper functions that could be used by all our tests.
The main ones needed are the ones to cope with Win9x missing several W-functions.
Another one used quite often in the tests is something like wine_dbgstr_w. [...]
A goal to keep in mind is that the conformance tests must be as independent from Wine as possible. This means that, except for wine/test.h of course, one should restrain from depending on Wine-specific headers. So if we add additional helper functions this essentially means they should be defined inwine/test.h.
That's why I said "something like" ;) The intent was to put any helpers in wine/test.h.
Also I feel it would be nice to keep the tests independent from msvcrt, especially on the Wine side (this to keep tests of low-level libraries from depending on high-level libraries, i.e. msvcrt). But maybe not everyone feels that way. That would mean we cannot depend on "%S" (unless one of the lower level Wine libraries (crtdll?) supports something like it too).
Agreed. My thought was that if Wine has proper support for "%S" we didn't need that wine_dbgstr_w clone. I get your point about the high-level libraries. -- Cheers, Paul.
participants (4)
-
Detlef Riekenberg -
Francois Gouget -
lats -
Paul Vriens