Re: [2/5] ntdll/tests: Implement tests for data execution prevention.
"Michael Karcher" <wine(a)mkarcher.dialup.fu-berlin.de> wrote:
The tests will be skipped on Wine until next patch, as the not-yet-implemented NtQueryInformationProcess(...,ProcessExecuteFlags,...,...) call is used to detect a DEP-capable platform.
These tests should added to existing dlls/ntdll/tests/exception.c framework. -- Dmitry.
Spotted on Reddit's frontpage wine-patches the black hole of code? http://kazade.livejournal.com/2451.html ____________________________________________________________________________________ Access Yahoo!7 Mail on your mobile. Anytime. Anywhere. Show me how: http://au.mobile.yahoo.com/mail
On Mon, Jul 27, 2009 at 8:09 AM, nn<saturn_systems(a)yahoo.com> wrote:
Spotted on Reddit's frontpage
wine-patches the black hole of code?
http://kazade.livejournal.com/2451.html
____________________________________________________________________________________ Access Yahoo!7 Mail on your mobile. Anytime. Anywhere. Show me how: http://au.mobile.yahoo.com/mail
I used to think it was difficult to get a patch into Wine - until I started sending patches to some other open source projects. It never took more than 2 days for a Wine patch I sent it to get accepted. By comparison, I submitted a modest OpenJDK patch (http://bugs.openjdk.java.net/show_bug.cgi?id=100041) around May 2008, I've had to completely rewrite it once, it's on the 5th revision (excluding 2 more revisions from before their bugzilla was opened), and it's still not accepted. IRC is a dream compared to weeks/months of waiting for your patch sponsor to reply on bugzilla. Think Wine doesn't accept patches easily, and it's hard to get feedback? Think again. Damjan Jovanovic
"Damjan Jovanovic" <damjan.jov(a)gmail.com> wrote:
Think Wine doesn't accept patches easily, and it's hard to get feedback? Think again.
I think it's not worth an effort to take seriously one post of apparently clueless anonymous user and a forward to wine-devel of another anonymous user. We've been through this "maintenance/ governance" subject before, no need to iterate. -- Dmitry.
Dmitry Timoshkov wrote:
"Damjan Jovanovic" <damjan.jov(a)gmail.com> wrote:
Think Wine doesn't accept patches easily, and it's hard to get feedback? Think again.
I think it's not worth an effort to take seriously one post of apparently clueless anonymous user and a forward to wine-devel of another anonymous user. We've been through this "maintenance/ governance" subject before, no need to iterate.
I'd rather have the opposite problem. We should be inundated with praise for how easy and fun it is to become a Wine developer. Instead of worries about silently dropped patches, contributors should be complaining about how they got too much help. First the patchwatcher tool told them their first patch broke the test suite on a platform they didn't think of. Then their second patch, which passed, was put on a landing page where another developer could click a button and send a review. Then their third patch sat in the queue for two weeks because Alexandre was on vacation, so patchwatcher again sent them an email suggesting they check in on IRC to see if there were other issues. It's only a vision now, but that's the kind of problem with sending patches I'd like us to be dismissing as nonsense. I'll be working on getting patchwatcher back online this week and Luke (the author of that article) already has a prototype of the patch tracking system he mentions. Thanks, Scott Ritchie
On Monday 27 July 2009 13:08:44 Scott Ritchie wrote:
First the patchwatcher tool told them their first patch broke the test suite on a platform they didn't think of.
Probably doable, once we get patchwatcher back up.
Then their second patch, which passed, was put on a landing page where another developer could click a button and send a review.
Android has a git-compatible code review tool called gerrit, iirc. It looks a bit painful to set up, so I've never given it a try myself. But even if we had such a tool I'm not yet convinced it would help much. There's too many areas where you're not scratching anybody else's itch. And if it doesn't have emacs integration, Alexandre won't use it ;). Of course I'm happy to be prooven wrong on this. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.
Am Montag, den 27.07.2009, 13:28 +0900 schrieb Dmitry Timoshkov:
The tests will be skipped on Wine until next patch, as the not-yet-implemented NtQueryInformationProcess(...,ProcessExecuteFlags,...,...) call is used to detect a DEP-capable platform. These tests should added to existing dlls/ntdll/tests/exception.c framework. You are right, I will resubmit the series. I was just grepping for "__TRY" in the tests to find a source file to add to, so I didn't find that stuff because it sets up the handler manually.
Regards, Michael Karcher
participants (6)
-
Damjan Jovanovic -
Dmitry Timoshkov -
Kai Blin -
Michael Karcher -
nn -
Scott Ritchie