Re: [PATCH] gdiplus/tests: Test for initial properties of adjustable arrow caps

[Vincent Povirk]

On Fri, Dec 16, 2016 at 6:21 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> +    stat = GdipGetCustomLineCapBaseInset((GpCustomLineCap*)cap, &inset);
> +    ok(stat == Ok, "Unexpected return code, %d\n", stat);
> +

It isn't enough to reject the patch, but I'm curious why you don't
test this value.

[PATCH] gdiplus/tests: Test for initial properties of adjustable arrow caps

[Nikolay Sivov]

On 19.12.2016 20:46, Vincent Povirk wrote:
> On Fri, Dec 16, 2016 at 6:21 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> > +    stat = GdipGetCustomLineCapBaseInset((GpCustomLineCap*)cap, &inset);
> > +    ok(stat == Ok, "Unexpected return code, %d\n", stat);
> > +
> > It isn't enough to reject the patch, but I'm curious why you don't
> > test this value.

I only tested this briefly, inset depends on width/height ratio. It felt
like one test is not enough,
so I decided to leave it to come back later. That of course means I can
remove this call altogether.