[PATCH 3/3] server: Always block overlapped device requests until driver dispatches them.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  dlls/ntdll/file.c                  |  2 +-
  dlls/ntoskrnl.exe/tests/ntoskrnl.c | 18 ------------------
  server/async.c                     | 21 +++++++++++++++++++++
  server/device.c                    |  9 ++++++---
  server/file.h                      |  1 +
  5 files changed, 29 insertions(+), 22 deletions(-)

[Mathew Hodson]

On Thu, May 23, 2019 at 1:35 PM Jacek Caban <jacek(a)codeweavers.com> wrote:
> @@ -238,18 +234,13 @@ static void test_overlapped(void)
>      cancel_cnt = 0xdeadbeef;
>      res = DeviceIoControl(file, IOCTL_WINETEST_GET_CANCEL_COUNT, NULL, 0, &cancel_cnt, sizeof(cancel_cnt), NULL, &overlapped);
>      todo_wine
> -    ok(res, "DeviceIoControl failed: %u\n", GetLastError());
> -    if (!res && GetLastError() == ERROR_IO_PENDING) WaitForSingleObject(overlapped.hEvent, INFINITE);
> -    todo_wine
>      ok(cancel_cnt == 2, "cancel_cnt = %u\n", cancel_cnt);

Don't we still want to test the return value of DeviceIoControl here?

[Jacek Caban]

On 5/24/19 5:24 AM, Mathew Hodson wrote:
> On Thu, May 23, 2019 at 1:35 PM Jacek Caban <jacek(a)codeweavers.com> wrote:
> > @@ -238,18 +234,13 @@ static void test_overlapped(void)
> >       cancel_cnt = 0xdeadbeef;
> >       res = DeviceIoControl(file, IOCTL_WINETEST_GET_CANCEL_COUNT, NULL, 0, &cancel_cnt, sizeof(cancel_cnt), NULL, &overlapped);
> >       todo_wine
> > -    ok(res, "DeviceIoControl failed: %u\n", GetLastError());
> > -    if (!res && GetLastError() == ERROR_IO_PENDING) WaitForSingleObject(overlapped.hEvent, INFINITE);
> > -    todo_wine
> >       ok(cancel_cnt == 2, "cancel_cnt = %u\n", cancel_cnt);
> > Don't we still want to test the return value of DeviceIoControl here?

Yes, I didn't mean to remove that line.


Thanks,

Jacek