Re: [1/5] windowscodecs: Implement IWICBitmapScaler::GetSize.

[Dmitry Timoshkov]

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> static HRESULT WINAPI BitmapScaler_GetSize(IWICBitmapScaler *iface,
>      UINT *puiWidth, UINT *puiHeight)
>  {
> -    FIXME("(%p,%p,%p): stub\n", iface, puiWidth, puiHeight);
> +    BitmapScaler *This = impl_from_IWICBitmapScaler(iface);
> +    TRACE("(%p,%p,%p)\n", iface, puiWidth, puiHeight);
>
> -    return E_NOTIMPL;
> +    if (!This->source)
> +        return WINCODEC_ERR_WRONGSTATE;
> +
> +    *puiWidth = This->width;
> +    *puiHeight = This->height;
> +
> +    return S_OK;

This patch and remaning patches in the sequence completely miss any
parameter checking.

-- 
Dmitry.

[1/5] windowscodecs: Implement IWICBitmapScaler::GetSize.

[Vincent Povirk]

Good point. I'll resend with parameter checking.

On Wed, Jun 27, 2012 at 11:25 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> Vincent Povirk <madewokherd(a)gmail.com> wrote:
> >  static HRESULT WINAPI BitmapScaler_GetSize(IWICBitmapScaler *iface,
> >      UINT *puiWidth, UINT *puiHeight)
> >  {
> > -    FIXME("(%p,%p,%p): stub\n", iface, puiWidth, puiHeight);
> > +    BitmapScaler *This = impl_from_IWICBitmapScaler(iface);
> > +    TRACE("(%p,%p,%p)\n", iface, puiWidth, puiHeight);
> >
> > -    return E_NOTIMPL;
> > +    if (!This->source)
> > +        return WINCODEC_ERR_WRONGSTATE;
> > +
> > +    *puiWidth = This->width;
> > +    *puiHeight = This->height;
> > +
> > +    return S_OK;
>
> This patch and remaning patches in the sequence completely miss any
> parameter checking.
>
> --
> Dmitry.