Re: [PATCH] d3dx9_36: Stop crash when displaying effect errors

[Matteo Bruni]

2016-06-01 12:18 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>:
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  dlls/d3dx9_36/effect.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
> index 7772406..a72aa3a 100644
> --- a/dlls/d3dx9_36/effect.c
> +++ b/dlls/d3dx9_36/effect.c
> @@ -5969,7 +5969,7 @@ static HRESULT d3dx9_base_effect_init(struct d3dx9_base_effect *base,
>              if (bytecode)
>                  ID3D10Blob_Release(bytecode);
>              if (temp_errors)
> -                TRACE("%s\n", (char *)ID3D10Blob_GetBufferPointer(temp_errors));
> +                TRACE("%s\n", debugstr_a((char *)ID3D10Blob_GetBufferPointer(temp_errors)));
>              if (errors)
>                  *errors = temp_errors;
>              else if (temp_errors)
> --
> 2.8.1

What effect / application is crashing because of this and what are the errors?

[PATCH] d3dx9_36: Stop crash when displaying effect errors

[Alistair Leslie-Hughes]

Hi Matteo,

On 02/06/16 07:18, Matteo Bruni wrote:
> 2016-06-01 12:18 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>:
>
> What effect / application is crashing because of this and what are the errors?

The Game is Battlefield 1225 Demo.  I was investigating issue
https://bugs.winehq.org/show_bug.cgi?id=39652

I have
d3dcompiler_43 set to native.
d3d9_* set to buildin.

The errors generated are
"Shaders/commonVertexLight.fx(30,9): warning X3205: conversion from
larger type to smaller, possible loss of
data\nShaders/commonVertexLight.fx(31,7): warning X3205: conversion from
larger type to smaller, possible loss of
data\nShaders/commonVertexLight.fx(40,9): warning X3205: conversion from
larger"...

Best Regards
 Alistair Leslie-Hughes

[PATCH] d3dx9_36: Stop crash when displaying effect errors

[Matteo Bruni]

2016-06-02 9:56 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>:
> On 02/06/16 07:18, Matteo Bruni wrote:
> > 2016-06-01 12:18 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>:
> >
> > What effect / application is crashing because of this and what are the errors?
>
> The Game is Battlefield 1225 Demo.  I was investigating issue
> https://bugs.winehq.org/show_bug.cgi?id=39652
>
> I have
> d3dcompiler_43 set to native.
> d3d9_* set to buildin.
>
> The errors generated are
> "Shaders/commonVertexLight.fx(30,9): warning X3205: conversion from
> larger type to smaller, possible loss of
> data\nShaders/commonVertexLight.fx(31,7): warning X3205: conversion from
> larger type to smaller, possible loss of
> data\nShaders/commonVertexLight.fx(40,9): warning X3205: conversion from
> larger"...

Thanks. I think a better way to fix this is to break the TRACE message
over multiple lines. Maybe break on '\n' or every ~80 characters
(whichever comes first)?
> Best Regards
>  Alistair Leslie-Hughes