Re: [PATCH 1/3] x11drv: Move cached cursor position from under x11's lock and into it's own.

[Mike McCormack]

Vitaliy Margolen wrote:
> dlls/winex11.drv/mouse.c |   43 +++++++++++++++++++++++++++++++++----------

...
> POINT cursor_pos;
>
> +static CRITICAL_SECTION cursor_CritSection;

There's a reference to cursor_pos in dlls/winex11.drv/keyboard.c too, 
and you're missing a critical section around it.

Mike

[PATCH 1/3] x11drv: Move cached cursor position from under x11's lock and into it's own.

[Vitaliy Margolen]

Mike McCormack wrote:
> Vitaliy Margolen wrote:
> > POINT cursor_pos;
> >
> > +static CRITICAL_SECTION cursor_CritSection;
>
> There's a reference to cursor_pos in dlls/winex11.drv/keyboard.c too,
> and you're missing a critical section around it.

Oh thank you. I think it will need a temp variable there. It's inside
server call which is a critical section too. And trying to enter two
crit_sections is not a good idea AFAIK.

Vitaliy