Re: [3/5] widl: Simplify make_safearray

[Robert Shearman]

Dan Hipschman wrote:
> This patch just simplifies the make_safearray function.  It didn't need
> to be that complicated.  I tested the generated headers and typelibs
> with this patch applied (well, I do that with every patch in this series),
> and this doesn't change anything.

Is dlls/oleaut32/tests/tmarshal.tlb identical compared to before this 
patch is applied? If not, you won't get test failures in Wine, but you 
will when running tests in Windows.

-- 
Rob Shearman

[3/5] widl: Simplify make_safearray

[Dan Hipschman]

On Thu, May 10, 2007 at 10:47:26AM +0100, Robert Shearman wrote:
> Dan Hipschman wrote:
> > This patch just simplifies the make_safearray function.  It didn't need
> > to be that complicated.  I tested the generated headers and typelibs
> > with this patch applied (well, I do that with every patch in this series),
> > and this doesn't change anything.
>
> Is dlls/oleaut32/tests/tmarshal.tlb identical compared to before this 
> patch is applied? If not, you won't get test failures in Wine, but you 
> will when running tests in Windows.

Yes, I basically just use find -name '*.tlb' on the wine tree, so I get
all the typelibs.  Then I use the equivalent of hexdump | diff to check
that they don't change (other than the two-byte timestamp).