Re: [PATCH 3/3] urlmon: Use CopyBindInfo in InternetBindInfo_GetBindInfo

[Jacek Caban]

Hi Piotr,

On 03/08/12 13:00, Piotr Caban wrote:
> -
> -    *pbindinfo = This->bindinfo;
> -
> -    if(pbindinfo->szExtraInfo || pbindinfo->szCustomVerb)
> -        FIXME("copy strings\n");
> -
> -    if(pbindinfo->stgmedData.pUnkForRelease)
> -        IUnknown_AddRef(pbindinfo->stgmedData.pUnkForRelease);
> -
> -    if(pbindinfo->pUnk)
> -        IUnknown_AddRef(pbindinfo->pUnk);
> -
> -    return S_OK;
> +    pbindinfo->cbSize = sizeof(BINDINFO);

Isn't caller responsible for setting this?
> +    return CopyBindInfo(&This->bindinfo, pbindinfo);

Jacek