Re: msvideo.dll16: Implement DrawDibProfileDisplay

[Alexandre Julliard]

Bruno Jesus <00cpxxx(a)gmail.com> writes:
> @@ -35,7 +35,7 @@
>  111 stub DRAWDIBCHANGEPALETTE
>  112 pascal -ret16 DrawDibRealize(word word word) DrawDibRealize16
>  113 stub DRAWDIBTIME
> -114 stub DRAWDIBPROFILEDISPLAY
> +114 pascal -ret16 DrawDibProfileDisplay(segptr) DrawDibProfileDisplay16

segptr is not correct if you pass the pointer to 32-bit code.

-- 
Alexandre Julliard
julliard(a)winehq.org

msvideo.dll16: Implement DrawDibProfileDisplay

[Bruno Jesus]

On Thu, Jan 26, 2017 at 8:56 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Bruno Jesus <00cpxxx(a)gmail.com> writes:
> > @@ -35,7 +35,7 @@
> >  111 stub DRAWDIBCHANGEPALETTE
> >  112 pascal -ret16 DrawDibRealize(word word word) DrawDibRealize16
> >  113 stub DRAWDIBTIME
> > -114 stub DRAWDIBPROFILEDISPLAY
> > +114 pascal -ret16 DrawDibProfileDisplay(segptr) DrawDibProfileDisplay16
>
> segptr is not correct if you pass the pointer to 32-bit code.

Thanks for the reply, I wrote a 16-bit app that calls
DrawDibProfileDisplay [1][2] and indeed when I try to access any data
in the struct inside Wine it crashes. It worked for the bug and games
because the function is a stub and does nothing with the struct in
msvfw32.

What should be done then?

[1] http://alexa.pro.br/~bruno/wine/msvideo.exe
[2] http://alexa.pro.br/~bruno/wine/file.txt

Thanks in advance,
Bruno

msvideo.dll16: Implement DrawDibProfileDisplay

[Sebastian Lackner]

On 26.01.2017 23:47, Bruno Jesus wrote:
> On Thu, Jan 26, 2017 at 8:56 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> > Bruno Jesus <00cpxxx(a)gmail.com> writes:
> > > @@ -35,7 +35,7 @@
> > >  111 stub DRAWDIBCHANGEPALETTE
> > >  112 pascal -ret16 DrawDibRealize(word word word) DrawDibRealize16
> > >  113 stub DRAWDIBTIME
> > > -114 stub DRAWDIBPROFILEDISPLAY
> > > +114 pascal -ret16 DrawDibProfileDisplay(segptr) DrawDibProfileDisplay16
> >
> > segptr is not correct if you pass the pointer to 32-bit code.
>
> Thanks for the reply, I wrote a 16-bit app that calls
> DrawDibProfileDisplay [1][2] and indeed when I try to access any data
> in the struct inside Wine it crashes. It worked for the bug and games
> because the function is a stub and does nothing with the struct in
> msvfw32.
>
> What should be done then?

Use "ptr" instead in the specfile.
> [1] http://alexa.pro.br/~bruno/wine/msvideo.exe
> [2] http://alexa.pro.br/~bruno/wine/file.txt
>
> Thanks in advance,
> Bruno

msvideo.dll16: Implement DrawDibProfileDisplay

[Bruno Jesus]

On Thu, Jan 26, 2017 at 8:52 PM, Sebastian Lackner
<sebastian(a)fds-team.de> wrote:
> On 26.01.2017 23:47, Bruno Jesus wrote:
> > On Thu, Jan 26, 2017 at 8:56 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> > > Bruno Jesus <00cpxxx(a)gmail.com> writes:
> > > > @@ -35,7 +35,7 @@
> > > >  111 stub DRAWDIBCHANGEPALETTE
> > > >  112 pascal -ret16 DrawDibRealize(word word word) DrawDibRealize16
> > > >  113 stub DRAWDIBTIME
> > > > -114 stub DRAWDIBPROFILEDISPLAY
> > > > +114 pascal -ret16 DrawDibProfileDisplay(segptr) DrawDibProfileDisplay16
> > >
> > > segptr is not correct if you pass the pointer to 32-bit code.
> >
> > Thanks for the reply, I wrote a 16-bit app that calls
> > DrawDibProfileDisplay [1][2] and indeed when I try to access any data
> > in the struct inside Wine it crashes. It worked for the bug and games
> > because the function is a stub and does nothing with the struct in
> > msvfw32.
> >
> > What should be done then?
>
> Use "ptr" instead in the specfile.

It works, now I can read the struct data from inside msvfw32 correctly.

Thanks =)