Re: [PATCH 3/4] mshtml: Add helper function get_url_components

[Detlef Riekenberg]

On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote:
> +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW
> *url)
> +{
> +    const WCHAR *doc_url;
> +    if(!InternetCrackUrlW(doc_url, 0, 0, url)) {
> +        FIXME("InternetCrackUrlW failed\n");

Such a FIXME does not help to find the reason.
Dumping doc_url helps, but might add personal data to the log


-- 
 
By by ... Detlef

[PATCH 3/4] mshtml: Add helper function get_url_components

[Andrew Eikum]

Detlef Riekenberg wrote:
> On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote:
> > +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW
> > *url)
> > +{
> > +    const WCHAR *doc_url;
> > +    if(!InternetCrackUrlW(doc_url, 0, 0, url)) {
> > +        FIXME("InternetCrackUrlW failed\n");
>
> Such a FIXME does not help to find the reason.
> Dumping doc_url helps, but might add personal data to the log

Thanks for the comments.  I've resent the patches with most of your 
corrections added.

Andrew