Re: msxml3/test: Added ISAXXMLReader test. (4/18) (resend)
"Piotr Caban" <piotr.caban(a)gmail.com> wrote in message news:200807082053.43537.piotr.caban(a)gmail.com...
--- dlls/msxml3/tests/Makefile.in | 3 +- dlls/msxml3/tests/saxreader.c | 225 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 227 insertions(+), 1 deletions(-) create mode 100644 dlls/msxml3/tests/saxreader.c
hr = ISAXXMLReader_putContentHandler(reader, &contentHandler); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
Hi Piotr, What about more tests for invalid parameters? eg. hr = ISAXXMLReader_putContentHandler(reader, NULL); Add some tests for get_contentHandler to confirm that putContentHandler works. Best Regards Alistair Leslie-Hughes
On Tue, Jul 8, 2008 at 8:45 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote:
"Piotr Caban" <piotr.caban(a)gmail.com> wrote in message news:200807082053.43537.piotr.caban(a)gmail.com...
--- dlls/msxml3/tests/Makefile.in | 3 +- dlls/msxml3/tests/saxreader.c | 225 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 227 insertions(+), 1 deletions(-) create mode 100644 dlls/msxml3/tests/saxreader.c
hr = ISAXXMLReader_putContentHandler(reader, &contentHandler); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
Hi Piotr, What about more tests for invalid parameters? eg. hr = ISAXXMLReader_putContentHandler(reader, NULL);
Add some tests for get_contentHandler to confirm that putContentHandler works.
Alistair, Piotr already said that he's just trying to get the initial tests in. More tests can be added later, by Piotr and anyone else that feels like more tests are needed. -- James Hawkins
Alistair,
Piotr already said that he's just trying to get the initial tests in. More tests can be added later, by Piotr and anyone else that feels like more tests are needed.
Hi James, I know that, but with 18 patches sent, and this is only test for SAX. If there was another patch that added more tests, I would not of sent a reminder. Best Regards Alistair Leslie-Hughes
On Tue, Jul 8, 2008 at 9:07 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote:
Alistair,
Piotr already said that he's just trying to get the initial tests in. More tests can be added later, by Piotr and anyone else that feels like more tests are needed.
Hi James, I know that, but with 18 patches sent, and this is only test for SAX. If there was another patch that added more tests, I would not of sent a reminder.
I'm mentoring Piotr for SOC, and he knows that he needs to write more tests and plans on doing so. With these 18 patches, he was working to fix the Photoshop installer, not completely and thoroughly implement this feature. If you have a problem with the current implementation as represented by these patches, please let us know; otherwise, let's get these patches in and he'll submit more tests before the project is over (tests are a part of the project). -- James Hawkins
I'm mentoring Piotr for SOC, and he knows that he needs to write more tests and plans on doing so. With these 18 patches, he was working to fix the Photoshop installer, not completely and thoroughly implement this feature. If you have a problem with the current implementation as represented by these patches, please let us know; otherwise, let's get these patches in and he'll submit more tests before the project is over (tests are a part of the project).
Hi James, Wont say another word on Tests. (Hopefully we'll see a test patch shortly). I've had already had a look though the patches, and have made a few a comments. Best Regards Alistair Leslie-Hughes
participants (2)
-
Alistair Leslie-Hughes -
James Hawkins