Re: [PATCH] comctl32/listview: Do not select the first list item when drawing a marquee rectangle
On 22.05.2017 16:02, Hugh McMaster wrote:
Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> --- dlls/comctl32/listview.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index c681451..a117f83 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -3892,6 +3892,9 @@ static void LISTVIEW_MarqueeHighlight(LISTVIEW_INFO *infoPtr, const POINT *coord if ((scroll & SCROLL_DOWN) && (coords_orig->y >= infoPtr->rcList.bottom)) LISTVIEW_Scroll(infoPtr, 0, (coords_orig->y - infoPtr->rcList.bottom));
+ if (IsRectEmpty(&infoPtr->marqueeRect)) + infoPtr->marqueeRect = rect; + iterator_frameditems_absolute(&old_elems, infoPtr, &infoPtr->marqueeRect);
infoPtr->marqueeRect = rect;
I see what you mean, when you start selecting with marquee first item in report mode is always selected. This patch fixes that, but breaks ICON mode it seems - sometimes items are not selected when they are clearly intersect with marquee rectangle. Admittedly this selection mode is already funny in ICON mode, it does not use dead zones properly, so slight movement selects things, while it should check with icon rectangle when resized horizontally, and allow about half icon rectangle intersect marquee vertically before setting item state.
On Wednesday, 24 May 2017 4:34 AM, Nikolay Sivov wrote:
I see what you mean, when you start selecting with marquee first item in report mode is always selected. This patch fixes that, but breaks ICON mode it seems - sometimes items are not selected when they are clearly intersect with marquee rectangle. Admittedly this selection mode is already funny in ICON mode, it does not use dead zones properly, so slight movement selects things, while it should check with icon rectangle when resized horizontally, and allow about half icon rectangle intersect marquee vertically before setting item state.
How are you testing the ICON mode? With a particular program? I tried using Wine Explorer and didn't notice anything wrong with the marquee selection of the large icons.
On 24.05.2017 14:49, Hugh McMaster wrote:
On Wednesday, 24 May 2017 4:34 AM, Nikolay Sivov wrote:
I see what you mean, when you start selecting with marquee first item in report mode is always selected. This patch fixes that, but breaks ICON mode it seems - sometimes items are not selected when they are clearly intersect with marquee rectangle. Admittedly this selection mode is already funny in ICON mode, it does not use dead zones properly, so slight movement selects things, while it should check with icon rectangle when resized horizontally, and allow about half icon rectangle intersect marquee vertically before setting item state.
How are you testing the ICON mode? With a particular program? I tried using Wine Explorer and didn't notice anything wrong with the marquee selection of the large icons.
I'm using ControlSpy.
On Wednesday, 24 May 2017 4:34 AM, Nikolay Sivov wrote:
I see what you mean, when you start selecting with marquee first item in report mode is always selected. This patch fixes that, but breaks ICON mode it seems - sometimes items are not selected when they are clearly intersect with marquee rectangle.
Sorry for the delayed reply. Yes, I see what you mean by ICON mode.
Admittedly this selection mode is already funny in ICON mode, it does not use dead zones properly, so slight movement selects things, while it should check with icon rectangle when resized horizontally, and allow about half icon rectangle intersect marquee vertically before setting item state.
Personally, I don't see any noticeable difference in ICON mode selection behaviour when the patch is applied. But one thing is certain - the selection behaviour for that mode is largely broken.
participants (2)
-
Hugh McMaster -
Nikolay Sivov