Re: [2/10] WineD3D: Subclass queries
Stefan Dösinger <stefan(a)codeweavers.com> writes:
diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index d1ab9a3..9dff960 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1143,6 +1143,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; IWineD3DQueryImpl *object; /*NOTE: impl ref allowed since this is a create function */ HRESULT hr = WINED3DERR_NOTAVAILABLE; + const IWineD3DQueryVtbl *vtable;
/* Just a check to see if we support this type of query */ switch(Type) { @@ -1161,6 +1162,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE */ FIXME("(%p) Event query: Unimplemented, but pretending to be supported\n", This); } + vtable = &IWineD3DEventQuery_Vtbl; hr = WINED3D_OK; break;
So what is vtable set to in the other cases? -- Alexandre Julliard julliard(a)winehq.org
So what is vtable set to in the other cases? Ooops :-)
With my two patches the vtable is set for all supported queries, and the unsupported ones return an error, so things work, but it is still a broken thing and I'll send an updated patch
participants (2)
-
Alexandre Julliard -
Stefan Dösinger