Re: [Bug 889] - WINPOS_GetWinOffset() yields wrong offset
"wine-bugs" == wine-bugs <wine-bugs(a)winehq.com> writes:
wine-bugs> http://bugs.winehq.com/show_bug.cgi?id=889 ------- Additional wine-bugs> Comments From tony_lambregts(a)telusplanet.net 2002-07-21 09:59 wine-bugs> ------- I am not that familiar with wine internals either, wine-bugs> but if you submit a patch to wine_patches(a)winehq.com, I'm wine-bugs> sure that if there is something wrong with it someone will wine-bugs> point it out. No, it happens that patches get silently dropped... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes:
No,
it happens that patches get silently dropped...
In which case you have to resubmit, until it either gets included or you get an explanation. We may someday have a patch tracking system that makes sure nothing ever gets dropped, but in the meantime people are expected to keep track of the patches they submit. -- Alexandre Julliard julliard(a)winehq.com
Alexandre Julliard wrote:
Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes:
No,
it happens that patches get silently dropped...
In which case you have to resubmit, until it either gets included or you get an explanation. We may someday have a patch tracking system that makes sure nothing ever gets dropped, but in the meantime people are expected to keep track of the patches they submit.
Perhaps I was overly optomistic about having (constructive) comments. However I see no real problem with the current system of having each person keep track of their own patches. A silent drop may not be ideal but it is less of a hassle than a review process for each patch. At least at this point. Certainly having a patch for someone to look at will increase the likelyhood of some helpfull hints (or possiblely a better solution). If its really a hack job and totaly unacceptable then maybe you risk a flame, but it's probably still better than no patch. Tony Lambregts
"Tony" == Tony Lambregts <tony_lambregts(a)telusplanet.net> writes:
Tony> Alexandre Julliard wrote: >> Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: >>> No, >>> >>> it happens that patches get silently dropped... >>> >>> >> In which case you have to resubmit, until it either gets included or >> you get an explanation. We may someday have a patch tracking system >> that makes sure nothing ever gets dropped, but in the meantime people >> are expected to keep track of the patches they submit. >> >> >> Tony> Perhaps I was overly optomistic about having (constructive) Tony> comments. However I see no real problem with the current system Tony> of having each person keep track of their own patches. A silent Tony> drop may not be ideal but it is less of a hassle than a review Tony> process for each patch. At least at this point. I feel the thread was constructive... We now have clear instructions what to do and two resubmits, at least one triggered by that thread. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
participants (3)
-
Alexandre Julliard -
Tony Lambregts -
Uwe Bonnes