Re: [X11DRV] Re-add support for the 'UseXShm' config key.
Lionel Ulmer <lionel.ulmer(a)free.fr> writes:
Changelog: - the UseXShm key was still present but not used anymore
Do you actually need it? Otherwise I think we might as well remove it completely, clearly nobody depends on it since it has been broken for a long time. -- Alexandre Julliard julliard(a)winehq.com
Do you actually need it? Otherwise I think we might as well remove it completely, clearly nobody depends on it since it has been broken for a long time.
Well, sometimes, in some rare debugging cases, it's useful to have it, yeah. Basically, I was hunting down a GFX corruption bug and was wondering if it was due to the fact that the XShm code path is 'asynchronous' and that we sent two updates in a row while the first one was not yet finished processing on the X server side... And in doing this, I found out that the 'disable XShm' option did not work anymore and I sent this patch. Lionel -- Lionel Ulmer - http://www.bbrox.org/
Lionel Ulmer <lionel.ulmer(a)free.fr> writes:
Well, sometimes, in some rare debugging cases, it's useful to have it, yeah.
But is it useful enough to justify exposing it, documenting it, explaining to users they shouldn't touch it, etc.? IOW do you use it often enough that it's painful for you to have to modify the source and rebuild to disable it? -- Alexandre Julliard julliard(a)winehq.com
But is it useful enough to justify exposing it, documenting it, explaining to users they shouldn't touch it, etc.? IOW do you use it often enough that it's painful for you to have to modify the source and rebuild to disable it?
No, it's as easy for me to just add 'return NULL;' in the file and do a 'make install' in the x11drv directory. I will check the sample config file to see if it needs to be patched to remove this option there. Lionel -- Lionel Ulmer - http://www.bbrox.org/
participants (2)
-
Alexandre Julliard -
Lionel Ulmer