On Thu, 7 Oct 2004, Jon Griffiths wrote:
Hi,
If you #define VISIBLE and run the modified tests you will see that native and builtin produce slightly different output drawing some merged images.
IMHO it would be better to rely on the WINETEST_INTERACTIVE environment variable. WINETEST_INTERACTIVE is used by human beings to instruct the test to take special steps to ensure that they, the human beings, can check the test output. WINETEST_INTERACTIVE is already used by the sound tests so this would improve consistency. Another benefit would be the removal of #ifdefs. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds
Hi Francois,
IMHO it would be better to rely on the WINETEST_INTERACTIVE environment variable.
I got the use of VISIBLE from the listview and tab control tests, but WINETEST_INTERACTIVE does sounds like a better/more consistent approach. I'll try to get a patch for all 3 tests out in the next few days. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com
participants (2)
-
Francois Gouget -
Jon Griffiths