Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

[Alexandre Julliard]

Jeff Cook <jeff(a)deserettechnology.com> writes:
> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer)
>      for (id = 0; id < mmixer->chans; ++id)
>      {
>          line *mline = &mmixer->lines[id];
> +        if (!mline->elem)
> +        {
> +            break;
> +        }
>          int ofs = CONTROLSPERLINE * id;

You can't do that:

mixer.c: In function ‘fillcontrols’:
mixer.c:252: error: ISO C90 forbids mixed declarations and code

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

[Jeff Cook]

What compiler are you running? It works fine for me and I don't see
any errors or warnings.

On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Jeff Cook <jeff(a)deserettechnology.com> writes:
> > @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer)
> >      for (id = 0; id < mmixer->chans; ++id)
> >      {
> >          line *mline = &mmixer->lines[id];
> > +        if (!mline->elem)
> > +        {
> > +            break;
> > +        }
> >          int ofs = CONTROLSPERLINE * id;
>
> You can't do that:
>
> mixer.c: In function ‘fillcontrols’:
> mixer.c:252: error: ISO C90 forbids mixed declarations and code
>
> --
> Alexandre Julliard
> julliard(a)winehq.org

[PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

[Ricardo Filipe]

2010/8/2 Jeff Cook <jeff(a)deserettechnology.com>:
> What compiler are you running? It works fine for me and I don't see
> any errors or warnings.
>
> On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> > Jeff Cook <jeff(a)deserettechnology.com> writes:
> > > @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer)
> > >      for (id = 0; id < mmixer->chans; ++id)
> > >      {
> > >          line *mline = &mmixer->lines[id];
> > > +        if (!mline->elem)
> > > +        {
> > > +            break;
> > > +        }
> > >          int ofs = CONTROLSPERLINE * id;
> >
> > You can't do that:
> >
> > mixer.c: In function ‘fillcontrols’:
> > mixer.c:252: error: ISO C90 forbids mixed declarations and code
> >
> > --
> > Alexandre Julliard
> > julliard(a)winehq.org

it's not compiler related. you can't mix variable declarations with
code in C90 standard. just move that check to the end of all variable
declarations and it'll be fine.

[PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

[Michael Stefaniuc]

Jeff Cook wrote:
> What compiler are you running? It works fine for me and I don't see
> any errors or warnings.
> You are passing the compiler the wrong flags:
> -Wdeclaration-after-statement is set by default in Wine.
> On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> > Jeff Cook <jeff(a)deserettechnology.com> writes:
> > > @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer)
> > >      for (id = 0; id < mmixer->chans; ++id)
> > >      {
> > >          line *mline = &mmixer->lines[id];
> > > +        if (!mline->elem)
> > > +        {
> > > +            break;
> > > +        }
> > >          int ofs = CONTROLSPERLINE * id;
> > > You can't do that:
> >
> > mixer.c: In function ‘fillcontrols’:
> > mixer.c:252: error: ISO C90 forbids mixed declarations and code

bye
	michael

[PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

[sudemon]

On 03.08.2010 04:36, Jeff Cook wrote:
> What compiler are you running? It works fine for me and I don't see
> any errors or warnings.
> I also don't see any errors or warnings.

Аfter 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 commit - my games just 
crash on start without errors (windows version is win98). Found by 
Regression test (16 august master VS wine-1.3.0).

After this commands games don't crash:
$ git bisect reset
$ git show 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 | patch -p1 -R

[PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

[Jeff Cook]

On Tue, Aug 17, 2010 at 3:00 AM, sudemon <sudemon(a)gmail.com> wrote:
> On 03.08.2010 04:36, Jeff Cook wrote:
> > What compiler are you running? It works fine for me and I don't see
> > any errors or warnings.
>
> I also don't see any errors or warnings.
>
> Аfter 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 commit - my games just crash
> on start without errors (windows version is win98). Found by Regression test
> (16 august master VS wine-1.3.0).
>
> After this commands games don't crash:
> $ git bisect reset
> $ git show 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 | patch -p1 -R

Sudemon, check out bug 23902. http://bugs.winehq.org/show_bug.cgi?id=23902

Try compiling from latest git, one of the fixes in that thread has
already been committed. If that doesn't work, please try the patch
located here: http://bugs2.winehq.org/attachment.cgi?id=30459 .

From
Jeff