Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section.
On Jan 6, 2013, at 6:54 PM, Ken Thomases wrote:
diff --git a/loader/wine_info.plist.in b/loader/wine_info.plist.in new file mode 100644 index 0000000..c332649 --- /dev/null +++ b/loader/wine_info.plist.in @@ -0,0 +1,28 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> +<plist version="1.0"> +<dict> + <key>CFBundleDevelopmentRegion</key> + <string>English</string> + <key>CFBundleExecutable</key> + <string>wine</string> + <key>CFBundleIdentifier</key> + <string>org.winehq.wine</string> + <key>CFBundleInfoDictionaryVersion</key> + <string>6.0</string> + <key>CFBundleName</key> + <string>Wine</string> + <key>CFBundlePackageType</key> + <string>APPL</string> + <key>CFBundleShortVersionString</key> + <string>@PACKAGE_VERSION@</string> + <key>CFBundleSignature</key> + <string>????</string> + <key>CFBundleVersion</key> + <string>@PACKAGE_VERSION@</string> + <key>LSMinimumSystemVersion</key> + <string>10.6</string> With this, you won't be able to launch Wine from the Finder or with open(1) prior to 10.6.
Chip
+ <key>NSPrincipalClass</key> + <string>WineApplication</string> +</dict> +</plist>
On Mon, Jan 7, 2013 at 4:48 AM, Charles Davis <cdavis5x(a)gmail.com> wrote:
With this, you won't be able to launch Wine from the Finder or with open(1) prior to 10.6.
I don't see how you'd do use open or the Finder to launch wine, could you explain more detailed? If you're talking about --args (which I just learnt about), that was also added in 10.6. Regards, -- Per Johansson
On Jan 7, 2013, at 1:23 AM, Per Johansson wrote:
On Mon, Jan 7, 2013 at 4:48 AM, Charles Davis <cdavis5x(a)gmail.com> wrote:
With this, you won't be able to launch Wine from the Finder or with open(1) prior to 10.6.
I don't see how you'd do use open or the Finder to launch wine, could you explain more detailed?
Yeah, I'm not sure it's a real problem, but that key should probably not be there anyway. I'll resubmit with that removed. Thanks for reviewing. Cheers, Ken
On Jan 7, 2013, at 9:15 AM, Ken Thomases wrote:
On Jan 7, 2013, at 1:23 AM, Per Johansson wrote:
On Mon, Jan 7, 2013 at 4:48 AM, Charles Davis <cdavis5x(a)gmail.com> wrote:
With this, you won't be able to launch Wine from the Finder or with open(1) prior to 10.6.
I don't see how you'd do use open or the Finder to launch wine, could you explain more detailed?
Yeah, I'm not sure it's a real problem, It won't be--I don't imagine anyone would want to double-click on the Wine executable, and they certainly wouldn't use open(1) when they could just run wine(1) directly--unless Wine grows support for file associations on the Mac. Then, when some poor user stuck on Leopard double-clicks on a file, expecting it to open up with Wine, it'll fail, because Wine declared to LaunchServices that it can't run on Leopard. I might be mistaken, since we'd probably end up just emitting app bundles with shell scripts that exec wine(1) directly, where LS wouldn't be involved in launching Wine itself. One area that might still be a problem, though, is if we associate *.exe files with Wine itself: then when a user double-clicks on a Win32 executable, LS will go straight to executing Wine. Don't know if that's possible with embedded Info.plist files, though.
Chip
but that key should probably not be there anyway. I'll resubmit with that removed.
Thanks for reviewing.
Cheers, Ken
On Mon, Jan 7, 2013 at 11:24 AM, Charles Davis <cdavis5x(a)gmail.com> wrote:
One area that might still be a problem, though, is if we associate *.exe files with Wine itself: then when a user double-clicks on a Win32 executable, LS will go straight to executing Wine.
You shouldn't be doing that anyway. Any association for .exe files should use wine start /unix.
participants (4)
-
Charles Davis -
Ken Thomases -
Per Johansson -
Vincent Povirk