Re: [3/7] [wined3d] add NP2 fixup code to shader_arb_generate_pshader (resend)

[Stefan Dösinger]

Am Monday 29 June 2009 21:41:58 schrieb Tobias Jakobi:


+        const UINT max_lconsts = gl_info->ps_arb_max_local_constants;
Please use the GL_LIMITS macro for consistency

[3/7] [wined3d] add NP2 fixup code to shader_arb_generate_pshader (resend)

[Tobias Jakobi]

Won't work since the GL_LIMITS macro is defined in this way:

#define GL_LIMITS(ExtName)            (GLINFO_LOCATION.max_##ExtName)

I don't think changing the variable name is an option, since keeping
consistency there should be priority:
ps_arb_max_local_constants -> ??? (I don't think it's wise to drop the
ps_arb prefix, since it's specific to ARB and specific to PS).