[PATCH 02/10] gdi32: Use DC_ATTR for GetCurrentPositionEx implementation.
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/gdi32/dc.c | 13 ------------- dlls/gdi32/gdidc.c | 11 +++++++++++ dlls/gdi32/tests/metafile.c | 3 +++ 3 files changed, 14 insertions(+), 13 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=94231 Your paranoid android. === build (build log) === error: patch failed: dlls/gdi32/dc.c:1833 Task: Patch failed to apply === debiant2 (build log) === error: patch failed: dlls/gdi32/dc.c:1833 Task: Patch failed to apply === debiant2 (build log) === error: patch failed: dlls/gdi32/dc.c:1833 Task: Patch failed to apply
On Mon, Jul 19, 2021 at 11:25:08PM +0200, Jacek Caban wrote:
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/gdi32/dc.c | 13 ------------- dlls/gdi32/gdidc.c | 11 +++++++++++ dlls/gdi32/tests/metafile.c | 3 +++ 3 files changed, 14 insertions(+), 13 deletions(-)
This is failing to build: dlls/gdi32/gdidc.c: In function ‘GetCurrentPositionEx’: dlls/gdi32/gdidc.c:34:21: warning: implicit declaration of function ‘get_dc_attr’ [-Wimplicit-function-declaration] 34 | if (!(dc_attr = get_dc_attr( hdc ))) return FALSE; | ^~~~~~~~~~~ dlls/gdi32/gdidc.c:34:19: warning: assignment to ‘DC_ATTR *’ {aka ‘struct DC_ATTR *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 34 | if (!(dc_attr = get_dc_attr( hdc ))) return FALSE; | ^ Huw.
On 7/20/21 8:58 AM, Huw Davies wrote:
On Mon, Jul 19, 2021 at 11:25:08PM +0200, Jacek Caban wrote:
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/gdi32/dc.c | 13 ------------- dlls/gdi32/gdidc.c | 11 +++++++++++ dlls/gdi32/tests/metafile.c | 3 +++ 3 files changed, 14 insertions(+), 13 deletions(-) This is failing to build: dlls/gdi32/gdidc.c: In function ‘GetCurrentPositionEx’: dlls/gdi32/gdidc.c:34:21: warning: implicit declaration of function ‘get_dc_attr’ [-Wimplicit-function-declaration] 34 | if (!(dc_attr = get_dc_attr( hdc ))) return FALSE; | ^~~~~~~~~~~ dlls/gdi32/gdidc.c:34:19: warning: assignment to ‘DC_ATTR *’ {aka ‘struct DC_ATTR *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 34 | if (!(dc_attr = get_dc_attr( hdc ))) return FALSE; | ^
I messed up patch order before sending, sorry about that. Thanks, Jacek
participants (3)
-
Huw Davies -
Jacek Caban -
Marvin