Re: [PATCH v2] wined3d: Implement SM5 atomic_umax/min instructions.

[Józef Kucia]

On Sun, Dec 4, 2016 at 6:49 PM, Kimmo Myllyvirta
<kimmo.myllyvirta(a)gmail.com> wrote:
> @@ -897,6 +899,8 @@ static const struct wined3d_sm4_opcode_info opcode_table[] =
>     {WINED3D_SM5_OP_LD_STRUCTURED,                    WINED3DSIH_LD_STRUCTURED,                    "u",    "iiR"},
>     {WINED3D_SM5_OP_STORE_STRUCTURED,                 WINED3DSIH_STORE_STRUCTURED,                 "U",    "iiu"},
>     {WINED3D_SM5_OP_ATOMIC_IADD,                      WINED3DSIH_ATOMIC_IADD,                      "U",    "ii"},
> +    {WINED3D_SM5_OP_ATOMIC_UMAX,                      WINED3DSIH_ATOMIC_UMAX,                      "U",    "uu"},
> +    {WINED3D_SM5_OP_ATOMIC_UMIN,                      WINED3DSIH_ATOMIC_UMIN,                      "U",    "uu"},

This is wrong. The generated GLSL code will produce compiler errors.

FWIW, I should have patches for various atomics with some tests soon.

[PATCH v2] wined3d: Implement SM5 atomic_umax/min instructions.

[Kimmo Myllyvirta]

On 12/05/2016 01:12 PM, Józef Kucia wrote:
> FWIW, I should have patches for various atomics with some tests soon.

Thanks, I'll wait for those. Henri can reject my patch.