Re: user32/tests: Allow tracing in menu test

[Dmitry Timoshkov]

André Hentschel <nerv(a)dawncrow.de> wrote:
> +        if (winetest_debug > 1)
> +                trace("item #%u: fType %04x, fState %04x, wID %u, hSubMenu %p\n",
> +                      i, mii.fType, mii.fState, mii.wID, mii.hSubMenu);

Please use 4 spaces for indentation after 'if ()', not 8.

Also, what's the reason of this patch? There are several other similar
disabled debug traces in that file, anything special about this one?
And I'd suggest to simply replace if (0) by if (1) in the personal build
if you really need to see the traces.

-- 
Dmitry.

user32/tests: Allow tracing in menu test

[André Hentschel]

Am 23.09.2015 um 05:54 schrieb Dmitry Timoshkov:
> André Hentschel <nerv(a)dawncrow.de> wrote:
> > +        if (winetest_debug > 1)
> > +                trace("item #%u: fType %04x, fState %04x, wID %u, hSubMenu %p\n",
> > +                      i, mii.fType, mii.fState, mii.wID, mii.hSubMenu);
>
> Please use 4 spaces for indentation after 'if ()', not 8.

Oops, done.
> Also, what's the reason of this patch? There are several other similar
> disabled debug traces in that file, anything special about this one?

True, I fixed that.
> And I'd suggest to simply replace if (0) by if (1) in the personal build
> if you really need to see the traces.

We have the feature of enabling it based on winetest_debug, so we should use that.

The sense behind this patch is that I have a task from wineconf to send AJ
a trace log of what happens before:
Test failed: id 205: wID should be equal to hSubMenu
on w2k8 systems.
Strange enough is that I can't reproduce it by manually testbot runs anymore.

user32/tests: Allow tracing in menu test

[Aaryaman Vasishta]

On Thu, Sep 24, 2015 at 11:36 PM, André Hentschel <nerv(a)dawncrow.de> wrote:
> Strange enough is that I can't reproduce it by manually testbot runs
> anymore.

That's kinda odd. Could it be some kinda regression in the testbot itself?


Cheers,
Aaryaman

user32/tests: Allow tracing in menu test

[Francois Gouget]

On Thu, 24 Sep 2015, André Hentschel wrote:
[...]
> The sense behind this patch is that I have a task from wineconf to send AJ
> a trace log of what happens before:
> Test failed: id 205: wID should be equal to hSubMenu
> on w2k8 systems.
> Strange enough is that I can't reproduce it by manually testbot runs anymore.

Sometimes a test does not fail when run on its own but does when 
run as part of WineTest because previous tests changed something. 
Typically they left a window open or something like it.

But if you managed to reproduce the issue by running the test on its own 
before it may be something else.

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
              All generalizations are false, including this one.
                                 -- Mark Twain

user32/tests: Allow tracing in menu test

[André Hentschel]

Am 25.09.2015 um 10:45 schrieb Francois Gouget:
> On Thu, 24 Sep 2015, André Hentschel wrote:
> [...]
> > The sense behind this patch is that I have a task from wineconf to send AJ
> > a trace log of what happens before:
> > Test failed: id 205: wID should be equal to hSubMenu
> > on w2k8 systems.
> > Strange enough is that I can't reproduce it by manually testbot runs anymore.
>
> Sometimes a test does not fail when run on its own but does when 
> run as part of WineTest because previous tests changed something. 
> Typically they left a window open or something like it.
>
> But if you managed to reproduce the issue by running the test on its own 
> before it may be something else.

It's suddenly gone:
https://test.winehq.org/data/tests/user32:menu.html

And I was able to reproduce it back in July, see attachment