Re: New tests failing ...

[Alexandre Julliard]

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes:
> ChangeLog
> -------------
>   fixed tests in dlls/winspool/tests/info.c when wine runs in NT-like mode

This kind of things should only be done if there is an actual app that
depends on it. Otherwise we shouldn't do version checks at all, just
fix the test to cope with all versions.

-- 
Alexandre Julliard
julliard(a)winehq.com

New tests failing ...

[Stefan Leichter]

Am Dienstag 21 Januar 2003 20:02 schrieb Alexandre Julliard:
> Stefan Leichter <Stefan.Leichter(a)camLine.com> writes:
> > ChangeLog
> > -------------
> >   fixed tests in dlls/winspool/tests/info.c when wine runs in NT-like mode
>
> This kind of things should only be done if there is an actual app that
> depends on it. Otherwise we shouldn't do version checks at all, just
> fix the test to cope with all versions.

The behavior that is check in the tests is not documented. Does fixing the 
test mean in this case remove the test ? e.g. like this:

--- ../wine/dlls/winspool/tests/info.c	Wed Jan 15 01:50:48 2003
+++ dlls/winspool/tests/info.c	Tue Jan 21 21:14:09 2003
@@ -26,6 +26,7 @@
 {   LPBYTE buffer = NULL;
     DWORD  cbBuf, pcbNeeded;
     BOOL   res;
+#ifdef UNDOCUMENTED
     OSVERSIONINFOA ver;
 
     ver.dwOSVersionInfoSize = sizeof(OSVERSIONINFOA);
@@ -33,6 +34,7 @@
         ok( 0, "GetVersionExA failed!");
         return ;
     }
+#endif /* UNDOCUMENTED */
 
     (void) GetPrinterDriverDirectoryA( NULL, NULL, 1, NULL, 0, &cbBuf);
 
@@ -56,6 +58,7 @@
         "last error set to %ld instead of ERROR_INSUFFICIENT_BUFFER",
         GetLastError());
  
+#ifdef UNDOCUMENTED
     res = GetPrinterDriverDirectoryA( NULL, NULL, 1, NULL, cbBuf, &pcbNeeded);
     if(ver.dwPlatformId == VER_PLATFORM_WIN32_NT) {
         ok( !res , "expected result == 0, got %d", res);
@@ -91,6 +94,7 @@
             "last error set to %ld instead of ERROR_INVALID_PARAMETER",
              GetLastError());
     }
+#endif /* UNDOCUMENTED */
 
     HeapFree( GetProcessHeap(), 0, buffer);
 }

New tests failing ...

[Alexandre Julliard]

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes:
> The behavior that is check in the tests is not documented. Does fixing the 
> test mean in this case remove the test ? e.g. like this:

Either that, or accept both outcomes without version check. So instead
of doing:

  if (version is win95) ok(foo);
  else ok(bar);

do:

  ok( foo || bar );

This way it doesn't force Wine to replicate the version checks.

-- 
Alexandre Julliard
julliard(a)winehq.com

New tests failing ...

[Francois Gouget]

On 21 Jan 2003, Alexandre Julliard wrote:
> Stefan Leichter <Stefan.Leichter(a)camLine.com> writes:
> > ChangeLog
> > -------------
> >   fixed tests in dlls/winspool/tests/info.c when wine runs in NT-like mode
>
> This kind of things should only be done if there is an actual app that
> depends on it. Otherwise we shouldn't do version checks at all, just
> fix the test to cope with all versions.

Note that the winspool test passes successfully on Win95, Win98 and NT4.
I believe it passed on Windows XP too.
So while the fix doesn't look right, there seems to be something wrong
in Wine.


-- 
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
     We are Pentium of Borg. You will be approximated. Division is futile.