Re: winspool: Remove dead code (Clang)
23 Dec
2015
23 Dec
'15
2:23 a.m.
André Hentschel <nerv(a)dawncrow.de> writes:
@@ -4092,8 +4092,6 @@ static BOOL WINSPOOL_GetPrinter_1(HKEY hkeyPrinter, PRINTER_INFO_1W *pi1, if(WINSPOOL_GetStringFromReg(hkeyPrinter, DescriptionW, ptr, left, &size)) { if(space && size <= left) { pi1->pComment = (LPWSTR)ptr; - ptr += size; - left -= size; } else space = FALSE; *pcbNeeded += size;
There's a clear pattern to the code here, you don't want to break it. I'd suggest redesigning the helper functions to avoid all this duplication. -- Alexandre Julliard julliard(a)winehq.org
3643
Age (days ago)
3643
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alexandre Julliard