On March 28, 2004 5:22 am, Lionel Ulmer wrote:
+static const char *EditWndProc_dump_msg_name(UINT msg)
That's a nice effort, but this is real long name... What about dbgstr_msg()? Also, this is a real useful function, I think we should have a standard dbgstr_msg() function that knows about all standard messages. -- Dimi.
On Sun, Mar 28, 2004 at 11:24:44AM -0500, Dimitrie O. Paun wrote:
On March 28, 2004 5:22 am, Lionel Ulmer wrote:
+static const char *EditWndProc_dump_msg_name(UINT msg)
That's a nice effort, but this is real long name...
I am corrupted by my day job's coding rules which encourages long function name (thank god Meta-/ exists :-) ).
What about dbgstr_msg()? Also, this is a real useful function, I think we should have a standard dbgstr_msg() function that knows about all standard messages.
If the list of all 'known' Windows messages is easily extracted from Wine, I could do that and put it in some new file in dlls/user/ (like dlls/user/dbg_trace.c). For all the WM_* stuff in include/winuser.h it seems easy, but then how to find out all the 'control-specific' messages (like EM_*) ? Lionel -- Lionel Ulmer - http://www.bbrox.org/
On March 28, 2004 11:52 am, Lionel Ulmer wrote:
That's a nice effort, but this is real long name...
I am corrupted by my day job's coding rules which encourages long function name (thank god Meta-/ exists :-) ).
It's OK. It's good that you acknowladge the problem, this is the first step to recovery :) <g>
If the list of all 'known' Windows messages is easily extracted from Wine, I could do that and put it in some new file in dlls/user/ (like dlls/user/dbg_trace.c).
Not sure where to put this, we may need to run it by AJ.
For all the WM_* stuff in include/winuser.h it seems easy, but then how to find out all the 'control-specific' messages (like EM_*) ?
Most of them are in commctrl.h. If we miss some, people working on them will add them later, so don't worry too much if we're not 100% complete at first iteration. -- Dimi.
It's OK. It's good that you acknowladge the problem, this is the first step to recovery :) <g>
We will see what AJ says about the 'global' trace function to see if I resubmit or not (anyway, I forgot the '#undef FE' line, so I may resubmit anyway).
Not sure where to put this, we may need to run it by AJ.
Just to summarize for all : if we create an API like that, it needs to be callable by, for example, COMCTL32.. Which, of course, breaks DLL separation. So one way would be to put it in USER32 and GetProcAddress it from COMCTL32 (so the latter would still work on, for example, Win32 and will just work a bit better in Wine :-) ).
Most of them are in commctrl.h. If we miss some, people working on them will add them later, so don't worry too much if we're not 100% complete at first iteration.
OK, it should be pretty easy to do it. Or to add it in a Janitorial task :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/
participants (2)
-
Dimitrie O. Paun -
Lionel Ulmer