Re: WIDL: Add missing ignore attribute. Check for inapplicable attributes in typedef.

[Alexandre Julliard]

Saveliy Tretiakov <saveliyt(a)mail.ru> writes:
> ChangeLog:
> Saveliy Tretiakov <saveliyt(a)mail.ru>
> - Add missing ignore attribute.
> - Check for inapplicable attributes in typedef. Changed attribute
> parsing in a way Mike McCormack suggested.
> - Register type alias in typelib, if ATTR_PUBLIC is set.

I think checking values explicitly is preferable to encoding them in
the syntax, since it gives you a chance to provide meaningful
errors. If you rely on the parser all you'll get is a generic "syntax
error" with no clue to what you did wrong.

-- 
Alexandre Julliard
julliard(a)winehq.org

WIDL: Add missing ignore attribute. Check for inapplicable attributes in typedef.

[Saveliy Tretiakov]

I think it is still possible to implement meaningful error messages. A 
good overview of  how this can be done is here: 
http://www.cs.nmsu.edu/~jeffery/merr.html.
Anyway, if you disagree, I will resend patch with explicit error check.

Alexandre Julliard wrote:
> I think checking values explicitly is preferable to encoding them in
> the syntax, since it gives you a chance to provide meaningful
> errors. If you rely on the parser all you'll get is a generic "syntax
> error" with no clue to what you did wrong.