Re: [PATCH v4 2/2] ieframe: Add stub implementation of InternetExplorerManager.

[Jacek Caban]

On 15.09.2017 07:43, Zebediah Figura wrote:
> +HRESULT WINAPI InternetExplorerManager_Create(IClassFactory *iface, IUnknown *pOuter, REFIID riid, void **ppv)
> +{
> +    InternetExplorerManager *ret;
> +    HRESULT hr;
> +
> +    TRACE("(%p %s %p)\n", pOuter, debugstr_guid(riid), ppv);
> +
> +    if (!(ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ret))))
> +        return E_OUTOFMEMORY;
> +
> +    ret->IInternetExplorerManager_iface.lpVtbl = &InternetExplorerManager_vtbl;
> +    ret->ref = 1;
> +
> +    hr = IInternetExplorerManager_QueryInterface(&ret->IInternetExplorerManager_iface, riid, ppv);
> +    IInternetExplorerManager_Release(&ret->IInternetExplorerManager_iface);
> +
> +    return hres;

That doesn't compile.


Jacek

[PATCH v4 2/2] ieframe: Add stub implementation of InternetExplorerManager.

[Zebediah Figura]

On 09/15/2017 06:56 AM, Jacek Caban wrote:
> On 15.09.2017 07:43, Zebediah Figura wrote:
> > +HRESULT WINAPI InternetExplorerManager_Create(IClassFactory *iface, IUnknown *pOuter, REFIID riid, void **ppv)
> > +{
> > +    InternetExplorerManager *ret;
> > +    HRESULT hr;
> > +
> > +    TRACE("(%p %s %p)\n", pOuter, debugstr_guid(riid), ppv);
> > +
> > +    if (!(ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ret))))
> > +        return E_OUTOFMEMORY;
> > +
> > +    ret->IInternetExplorerManager_iface.lpVtbl = &InternetExplorerManager_vtbl;
> > +    ret->ref = 1;
> > +
> > +    hr = IInternetExplorerManager_QueryInterface(&ret->IInternetExplorerManager_iface, riid, ppv);
> > +    IInternetExplorerManager_Release(&ret->IInternetExplorerManager_iface);
> > +
> > +    return hres;
>
> That doesn't compile.
>
> Jacek

Whoops, thanks for the catch. I could have sworn I tested this...