Re: [1/3] comdlg32: Adjust the size of CHOOSE_COLOR dialog.
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
Adjusting size for the translation to fit.
You can't do that, read the comment in that file slightly before all common dialog templates. -- Dmitry.
On Fri, 17 Feb 2012, Dmitry Timoshkov wrote:
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
Adjusting size for the translation to fit.
You can't do that, read the comment in that file slightly before all common dialog templates.
That comment would deserve some explanation (the b96b3d15 commit message does no provide that explanation either). What are our next options? Can the control be resized just enough without changing the overall dialog size? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy
Francois Gouget <fgouget(a)free.fr> wrote:
That comment would deserve some explanation (the b96b3d15 commit message does no provide that explanation either).
What are our next options? Can the control be resized just enough without changing the overall dialog size?
Dialog templates must match the PSDK ones, applications do depend on dialog and controls sizes and positions, probably apps may depend on controls' text as well. -- Dmitry.
On Fri, 17 Feb 2012, Dmitry Timoshkov wrote:
Francois Gouget <fgouget(a)free.fr> wrote:
That comment would deserve some explanation (the b96b3d15 commit message does no provide that explanation either).
What are our next options? Can the control be resized just enough without changing the overall dialog size?
Dialog templates must match the PSDK ones, applications do depend on dialog and controls sizes and positions,
Do you have examples? What is it that they try to achieve that makes them depend on the dialog or control sizes (or positions)?
probably apps may depend on controls' text as well.
I wouldn't worry much about those as they would break in any non-English Windows version too. If the programmers were sloppy enough to depend on the control text then they certainly did not bother gathering the text used for each language along with potential variations across Windows versions. And in any case I don't think it's reasonable to require that all our translations use the same text as Windows. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.
2012/2/17 Francois Gouget <fgouget(a)free.fr>
On Fri, 17 Feb 2012, Dmitry Timoshkov wrote:
Francois Gouget <fgouget(a)free.fr> wrote:
That comment would deserve some explanation (the b96b3d15 commit message does no provide that explanation either).
What are our next options? Can the control be resized just enough without changing the overall dialog size?
Dialog templates must match the PSDK ones, applications do depend on dialog and controls sizes and positions,
Do you have examples? What is it that they try to achieve that makes them depend on the dialog or control sizes (or positions)?
I had forgotten about that, but last time I translated Wine, I ran into this problem and IIRC Julliard explained that some applications adjust the size of the dialog, removing or inserting widgets at will. It would look ugly for the Wine project if the widgets end up overlapping themselves in some applications even when LANG="en_US". If this patch is rejected, I could use "Rubro" instead of "Vermelho", although it's not appropriate in this case. Gustavo
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
If this patch is rejected, I could use "Rubro" instead of "Vermelho", although it's not appropriate in this case.
What Windows is using in that case? -- Dmitry.
Windows uses the translation "Vermelho". Comparing Wine's CHOOSE_COLOR with the one in Paint in Windows 7, the position of other widgets were changed for the text to fit. Either that or XN Resource Editor is lying to me :P The overall dialog seems to be just a bit larger in Windows because there is a blank space after the widgets. I'm attaching a screen capture on Win 7 for reference. Gustavo Em 18 de fevereiro de 2012 01:06, Dmitry Timoshkov <dmitry(a)baikal.ru> escreveu:
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
If this patch is rejected, I could use "Rubro" instead of "Vermelho", although it's not appropriate in this case.
What Windows is using in that case?
-- Dmitry.
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
Windows uses the translation "Vermelho". Comparing Wine's CHOOSE_COLOR with the one in Paint in Windows 7, the position of other widgets were changed for the text to fit. Either that or XN Resource Editor is lying to me :P The overall dialog seems to be just a bit larger in Windows because there is a blank space after the widgets.
I'm attaching a screen capture on Win 7 for reference.
You need to compare with a not themed version of the dialog. -- Dmitry.
Em 18 de fevereiro de 2012 02:35, Dmitry Timoshkov <dmitry(a)baikal.ru>escreveu:
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
Windows uses the translation "Vermelho". Comparing Wine's CHOOSE_COLOR with the one in Paint in Windows 7, the position of other widgets were changed for the text to fit. Either that or XN Resource Editor is lying to me :P The overall dialog seems to be just a bit larger in Windows because there is a blank space after the widgets.
I'm attaching a screen capture on Win 7 for reference.
You need to compare with a not themed version of the dialog.
I've opened Windows' condlg32.dll with XN Resource Editor in Windows. The dialog is exactly equal to the one I've sent.
Gustavo
It just occurred to me: did I violate the "Clean Room Guidelines" by using XN Resource to see that dialog? If that's the case, my apologies. Em 18 de fevereiro de 2012 14:13, Gustavo Henrique Milaré < gugamilare(a)gmail.com> escreveu:
Em 18 de fevereiro de 2012 02:35, Dmitry Timoshkov <dmitry(a)baikal.ru>escreveu:
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
Windows uses the translation "Vermelho". Comparing Wine's CHOOSE_COLOR with the one in Paint in Windows 7, the position of other widgets were changed for the text to fit. Either that or XN Resource Editor is lying to me :P The overall dialog seems to be just a bit larger in Windows because there is a blank space after the widgets.
I'm attaching a screen capture on Win 7 for reference.
You need to compare with a not themed version of the dialog.
I've opened Windows' condlg32.dll with XN Resource Editor in Windows. The
dialog is exactly equal to the one I've sent.
Gustavo
Yes, but the changes can likely be accepted if they are trivial/obvious. J. Leclanche 2012/2/18 Gustavo Henrique Milaré <gugamilare(a)gmail.com>
It just occurred to me: did I violate the "Clean Room Guidelines" by using XN Resource to see that dialog?
If that's the case, my apologies.
Em 18 de fevereiro de 2012 14:13, Gustavo Henrique Milaré < gugamilare(a)gmail.com> escreveu:
Em 18 de fevereiro de 2012 02:35, Dmitry Timoshkov <dmitry(a)baikal.ru>escreveu:
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
Windows uses the translation "Vermelho". Comparing Wine's CHOOSE_COLOR with the one in Paint in Windows 7, the position of other widgets were changed for the text to fit. Either that or XN Resource Editor is lying to me :P The overall dialog seems to be just a bit larger in Windows because there is a blank space after the widgets.
I'm attaching a screen capture on Win 7 for reference.
You need to compare with a not themed version of the dialog.
I've opened Windows' condlg32.dll with XN Resource Editor in Windows.
The dialog is exactly equal to the one I've sent.
Gustavo
Gustavo Henrique Milaré <gugamilare(a)gmail.com> wrote:
It just occurred to me: did I violate the "Clean Room Guidelines" by using XN Resource to see that dialog?
Not really, that dialog template is a part of PSDK. -- Dmitry.
participants (4)
-
Dmitry Timoshkov -
Francois Gouget -
Gustavo Henrique Milaré -
Jerome Leclanche