Re: wininet: Always create a URL cache entry.

[Jacek Caban]

Hi Hans,

Hans Leidekker wrote:
> Fixes file downloads in ie7.
>
> -Hans
>
> diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
> index 8f9f404..2721427 100644
> --- a/dlls/wininet/http.c
> +++ b/dlls/wininet/http.c
> @@ -3807,8 +3807,7 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWININETHTTPREQW lpwhr, LPCWSTR lpszHeaders,
>      }
>      while (loop_next);
>
> -    /* FIXME: Better check, when we have to create the cache file */
> -    if(bSuccess && (lpwhr->hdr.dwFlags & INTERNET_FLAG_NEED_FILE)) {
> +    if(bSuccess) {

I think we should check at least INTERNET_FLAG_NO_CACHE_WRITE flag here.


Jacek

wininet: Always create a URL cache entry.

[Hans Leidekker]

On Tuesday 16 June 2009 11:15:49 am Jacek Caban wrote:
> > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
> > index 8f9f404..2721427 100644
> > --- a/dlls/wininet/http.c
> > +++ b/dlls/wininet/http.c
> > @@ -3807,8 +3807,7 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWININETHTTPREQW lpwhr, LPCWSTR lpszHeaders,
> >      }
> >      while (loop_next);
> >
> > -    /* FIXME: Better check, when we have to create the cache file */
> > -    if(bSuccess && (lpwhr->hdr.dwFlags & INTERNET_FLAG_NEED_FILE)) {
> > +    if(bSuccess) {
>
> I think we should check at least INTERNET_FLAG_NO_CACHE_WRITE flag here.

This flag is used to instruct the server to not cache anything via the
Cache-Control header. And an existing test in test_http_cache() implies
that it doesn't affect local caching.

 -Hans