Re: Bug Fix With Delay load function in Shell32

Hi!

This isn't the best solution since GetShellOle() initializes the ole subsystem by calling
OleInitialize(). This is not nessesary for _CoCreateInstance().

Bye

Juergen
> This fixes a bug in Shell32 where one function caused the function
> responsible for setting up the delay load function pointers to assume they
> had already been loaded, and they hadn't.
> Maybe we should make the hShellOle32 variable static so this can't happen
> again.
>
> ChangeLog:
> - Set up all delay load functions in GetShellOle() function to avoid
> GetShellOle assuming that they were all loaded when they weren't
>
> Rob

--
juergen.schmied(a)debitel.net
FAX über T-Online Fax&Fon: 01805 060 334 316 35 (12Cent/Min)

Bug Fix With Delay load function in Shell32 (version2)

[Robert Shearman]

Here is the updated patch:
> -----Original Message-----
> From: Jürgen Schmied [mailto:j.schmied(a)t-online.de]
> Sent: 12 January 2003 13:45
> To: Robert Shearman; wine-devel(a)winehq.com
> Subject: Re: Bug Fix With Delay load function in Shell32
> > ChangeLog:
> > - Set up all delay load functions in GetShellOle() function to avoid
> > GetShellOle assuming that they were all loaded when they weren't
> This isn't the best solution since GetShellOle() initializes the
> ole subsystem by calling
> OleInitialize(). This is not nessesary for _CoCreateInstance().

ChangeLog:
- Seperate the HINSTANCEs used by GetShellOle() and other delay load
functions

new to wine and would like to be actively involved.

[Shravan Sadasivan]

Hi,
    I am new to the wine developement community and would like to actively
get involved in the activities in this community. Could anyone please
educate me on how i can go about doing that?.. I have strong developement
skills in C and Perl.. and have worked with converting C source code in
informix. Awaiting more from your side..

TIA

Warm Regards,
Shravan

----- Original Message -----
From: "Robert Shearman" <R.J.Shearman(a)warwick.ac.uk>
To: "Jürgen Schmied" <j.schmied(a)t-online.de>; <wine-devel(a)winehq.com>
Sent: Sunday, January 12, 2003 10:36 PM
Subject: Bug Fix With Delay load function in Shell32 (version2)
> Here is the updated patch:
> > -----Original Message-----
> > From: Jürgen Schmied [mailto:j.schmied(a)t-online.de]
> > Sent: 12 January 2003 13:45
> > To: Robert Shearman; wine-devel(a)winehq.com
> > Subject: Re: Bug Fix With Delay load function in Shell32
> > > ChangeLog:
> > > - Set up all delay load functions in GetShellOle() function to avoid
> > > GetShellOle assuming that they were all loaded when they weren't
> > This isn't the best solution since GetShellOle() initializes the
> > ole subsystem by calling
> > OleInitialize(). This is not nessesary for _CoCreateInstance().
>
> ChangeLog:
> - Seperate the HINSTANCEs used by GetShellOle() and other delay load
> functions

new to wine and would like to be actively involved.

[Tom Wickline]

Shravan Sadasivan wrote:
> Hi,
>     I am new to the wine developement community and would like to actively
> get involved in the activities in this community. Could anyone please
> educate me on how i can go about doing that?.. I have strong developement
> skills in C and Perl.. and have worked with converting C source code in
> informix. Awaiting more from your side..
>
> TIA
>
> Warm Regards,
> Shravan

Here is a starter guide :) I'm sure there is alot of other goodies to
work on as well.
See : http://www.dssd.ca/wine/Wine-Contrib-0.7.html

hope this helps

Tom

new to wine and would like to be actively involved.

[Dan Kegel]

Tom Wickline wrote:
> > I am new to the wine developement community and would like to 
> > actively
> > get involved in the activities in this community. Could anyone please
> > educate me on how i can go about doing that?.. I have strong developement
> > skills in C and Perl.. and have worked with converting C source code in
> > informix. Awaiting more from your side..
>
> Here is a starter guide :) I'm sure there is alot of other goodies to
> work on as well.
> See : http://www.dssd.ca/wine/Wine-Contrib-0.7.html

I strongly recommend adding to the conformance test suite
as a first step for people with strong C skills!

By the way,
http://www.dssd.ca/wine/Wine-Contrib-0.7.html#conf_tests
still says
"Either C or perl skills"
but perhaps this should just say
"C programming skills"
as the Perl tests were removed.
- Dan

-- 
Dan Kegel
http://www.kegel.com
http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

new to wine and would like to be actively involved.

[Tom Wickline]

Dan Kegel wrote:
> By the way,
> http://www.dssd.ca/wine/Wine-Contrib-0.7.html#conf_tests
> still says
> "Either C or perl skills"
> but perhaps this should just say
> "C programming skills"
> as the Perl tests were removed.
> - Dan

Thanks Ill note to do that in 0.8

Tom

new to wine and would like to be actively involved.

[Shravan Sadasivan]

Sorry about my previous email people... I just realized I should have said 
virtual "wine" and not beer..

Told you I would be ignorant in the beginning ;)

Shravan

At 11:22 PM 1/13/2003 -0800, Dan Kegel wrote:
> Tom Wickline wrote:
> > > I am new to the wine developement community and would like to actively
> > > get involved in the activities in this community. Could anyone please
> > > educate me on how i can go about doing that?.. I have strong developement
> > > skills in C and Perl.. and have worked with converting C source code in
> > > informix. Awaiting more from your side..
> >
> > Here is a starter guide :) I'm sure there is alot of other goodies to
> > work on as well.
> > See : http://www.dssd.ca/wine/Wine-Contrib-0.7.html
>
> I strongly recommend adding to the conformance test suite
> as a first step for people with strong C skills!
>
> By the way,
> http://www.dssd.ca/wine/Wine-Contrib-0.7.html#conf_tests
> still says
> "Either C or perl skills"
> but perhaps this should just say
> "C programming skills"
> as the Perl tests were removed.
> - Dan
>
> --
> Dan Kegel
> http://www.kegel.com
> http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

new to wine and would like to be actively involved.

[Dimitrie O. Paun]

On January 13, 2003 02:09 pm, Shravan Sadasivan wrote:
> I have strong developement
> skills in C and Perl.. and have worked with converting C source code in
> informix. Awaiting more from your side..

Hi Shravan,

There are plenty of things to do, you will find some of them
on these pages:
  http://www.dssd.ca/wine/

Check out the Fun/Janitorial/Winelib/0.9 TODO/Contrib pages.

Welcome to the team!

-- 
Dimi.

P.S. I hope you know we can not accept contributions unless they
     have been conceived while under the influence of at _least_
     3-5 glasses of (good) wine... :)

new to wine and would like to be actively involved.

[Shravan Sadasivan]

Hi Team,
         A big thank you to all you guys for the warm welcome and the tips. 
I will get down to following your suggestions actively and you will see me 
taking part in discussions as well as coming up with suggestions for the 
betterment of wine. Please bear with me in case I am a little ignorant 
towards the beginning :) .. otherwise virtual beer's to one and all on this 
list.

Shravan



At 05:20 PM 1/13/2003 -0500, Dimitrie O. Paun wrote:
> On January 13, 2003 02:09 pm, Shravan Sadasivan wrote:
> > I have strong developement
> > skills in C and Perl.. and have worked with converting C source code in
> > informix. Awaiting more from your side..
>
> Hi Shravan,
>
> There are plenty of things to do, you will find some of them
> on these pages:
>   http://www.dssd.ca/wine/
>
> Check out the Fun/Janitorial/Winelib/0.9 TODO/Contrib pages.
>
> Welcome to the team!
>
> --
> Dimi.
>
> P.S. I hope you know we can not accept contributions unless they
>      have been conceived while under the influence of at _least_
>      3-5 glasses of (good) wine... :)